From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Reinecke Subject: Re: [PATCH v3 03/11] scsi: sd_zbc: Fix sd_zbc_check_zones() error checks Date: Fri, 12 Oct 2018 09:35:41 +0200 Message-ID: References: <20181012023012.29923-1-damien.lemoal@wdc.com> <20181012023012.29923-4-damien.lemoal@wdc.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181012023012.29923-4-damien.lemoal@wdc.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Damien Le Moal , linux-block@vger.kernel.org, Jens Axboe , linux-scsi@vger.kernel.org, "Martin K . Petersen" , dm-devel@redhat.com, Mike Snitzer Cc: Christoph Hellwig , Matias Bjorling List-Id: dm-devel.ids T24gMTAvMTIvMTggNDozMCBBTSwgRGFtaWVuIExlIE1vYWwgd3JvdGU6Cj4gVGhlIDMyIGJpdHMg b3ZlcmZsb3cgY2hlY2sgZm9yIHRoZSB6b25lIHNpemUgdmFsdWUgaXMgYWxyZWFkeSBkb25lCj4g d2l0aGluIHNkX3piY19jaGVja196b25lcygpIHdpdGggdGhlIHRlc3Q6Cj4gCj4gfSBlbHNlIGlm IChsb2dpY2FsX3RvX3NlY3RvcnMoc2RrcC0+ZGV2aWNlLCB6b25lX2Jsb2NrcykgPiBVSU5UX01B WCkgewo+IAo+IHNvIHRoZXJlIGlzIG5vIG5lZWQgdG8gY2hlY2sgYWdhaW4gZm9yIGFuIG91dCBv ZiByYW5nZSB2YWx1ZSBpbgo+IHNkX3piY19yZWFkX3pvbmVzKCkuIFNpbXBsaWZ5IHRoZSBjb2Rl IGFuZCBmaXggc2RfemJjX2NoZWNrX3pvbmVzKCkKPiBlcnJvciByZXR1cm4gdG8gLUVGQklHIGlu c3RlYWQgb2YgLUVOT0RFViBpZiB0aGUgem9uZSBzaXplIGlzIHRvbyBsYXJnZS4KPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBEYW1pZW4gTGUgTW9hbCA8ZGFtaWVuLmxlbW9hbEB3ZGMuY29tPgo+IFJldmll d2VkLWJ5OiBDaHJpc3RvcGggSGVsbHdpZyA8aGNoQGxzdC5kZT4KPiAtLS0KPiAgIGRyaXZlcnMv c2NzaS9zZF96YmMuYyB8IDE1ICsrKysrKy0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDYg aW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9z Y3NpL3NkX3piYy5jIGIvZHJpdmVycy9zY3NpL3NkX3piYy5jCj4gaW5kZXggY2E3M2M0NjkzMWMw Li40NGI2NGI0YTkyMmEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9zY3NpL3NkX3piYy5jCj4gKysr IGIvZHJpdmVycy9zY3NpL3NkX3piYy5jCj4gQEAgLTM3Myw3ICszNzMsNyBAQCBzdGF0aWMgaW50 IHNkX3piY19jaGVja196b25lZF9jaGFyYWN0ZXJpc3RpY3Moc3RydWN0IHNjc2lfZGlzayAqc2Rr cCwKPiAgICAqIFJldHVybnMgdGhlIHpvbmUgc2l6ZSBpbiBudW1iZXIgb2YgYmxvY2tzIHVwb24g c3VjY2VzcyBvciBhbiBlcnJvciBjb2RlCj4gICAgKiB1cG9uIGZhaWx1cmUuCj4gICAgKi8KPiAt c3RhdGljIHM2NCBzZF96YmNfY2hlY2tfem9uZXMoc3RydWN0IHNjc2lfZGlzayAqc2RrcCkKPiAr c3RhdGljIHMzMiBzZF96YmNfY2hlY2tfem9uZXMoc3RydWN0IHNjc2lfZGlzayAqc2RrcCkKPiAg IHsKPiAgIAl1NjQgem9uZV9ibG9ja3MgPSAwOwo+ICAgCXNlY3Rvcl90IG1heF9sYmEsIGJsb2Nr ID0gMDsKRG9lcyB0aGlzIGhhdmUgdG8gYmUgYW4gJ3MzMicgPwpTZWVpbmcgdGhhdCBpdCdzIG92 ZXJsb2FkZWQgd2l0aCBhbiBlcnJvciBjb2RlLCBhbmQgbmV2ZXIgc2VudCB0byBhbnkgCmhhcmR3 YXJlLCBjYW4ndCB3ZSBqdXN0IG1ha2UgaXQgYSBzaW1wbGUgJ2ludCcgPwoKPiBAQCAtNDcyLDcg KzQ3Miw3IEBAIHN0YXRpYyBzNjQgc2RfemJjX2NoZWNrX3pvbmVzKHN0cnVjdCBzY3NpX2Rpc2sg KnNka3ApCj4gICAJCWlmIChzZGtwLT5maXJzdF9zY2FuKQo+ICAgCQkJc2RfcHJpbnRrKEtFUk5f Tk9USUNFLCBzZGtwLAo+ICAgCQkJCSAgIlpvbmUgc2l6ZSB0b28gbGFyZ2VcbiIpOwo+IC0JCXJl dCA9IC1FTk9ERVY7Cj4gKwkJcmV0ID0gLUVGQklHOwo+ICAgCX0gZWxzZSB7Cj4gICAJCXJldCA9 IHpvbmVfYmxvY2tzOwo+ICAgCX0KPiBAQCAtNjY4LDggKzY2OCw3IEBAIHN0YXRpYyBpbnQgc2Rf emJjX3NldHVwKHN0cnVjdCBzY3NpX2Rpc2sgKnNka3AsIHUzMiB6b25lX2Jsb2NrcykKPiAgIAo+ ICAgaW50IHNkX3piY19yZWFkX3pvbmVzKHN0cnVjdCBzY3NpX2Rpc2sgKnNka3AsIHVuc2lnbmVk IGNoYXIgKmJ1ZikKPiAgIHsKPiAtCWludDY0X3Qgem9uZV9ibG9ja3M7Cj4gLQlpbnQgcmV0Owo+ ICsJaW50IHJldCwgem9uZV9ibG9ja3M7Cj4gICAKPiAgIAlpZiAoIXNkX2lzX3pvbmVkKHNka3Ap KQo+ICAgCQkvKgo+IEBAIC02ODgsMTIgKzY4NywxMCBAQCBpbnQgc2RfemJjX3JlYWRfem9uZXMo c3RydWN0IHNjc2lfZGlzayAqc2RrcCwgdW5zaWduZWQgY2hhciAqYnVmKQo+ICAgCSAqIGFuIGV2 ZW50dWFsIGxhc3QgcnVudCB6b25lKSB0aGF0IGlzIGEgcG93ZXIgb2YgMiBhcmUgc3VwcG9ydGVk Lgo+ICAgCSAqLwo+ICAgCXpvbmVfYmxvY2tzID0gc2RfemJjX2NoZWNrX3pvbmVzKHNka3ApOwo+ IC0JcmV0ID0gLUVGQklHOwo+IC0JaWYgKHpvbmVfYmxvY2tzICE9ICh1MzIpem9uZV9ibG9ja3Mp Cj4gLQkJZ290byBlcnI7Cj4gLQlyZXQgPSB6b25lX2Jsb2NrczsKPiAtCWlmIChyZXQgPCAwKQo+ ICsJaWYgKHpvbmVfYmxvY2tzIDwgMCkgewo+ICsJCXJldCA9IHpvbmVfYmxvY2tzOwo+ICAgCQln b3RvIGVycjsKPiArCX0KPiAgIAo+ICAgCS8qIFRoZSBkcml2ZSBzYXRpc2ZpZXMgdGhlIGtlcm5l bCByZXN0cmljdGlvbnM6IHNldCBpdCB1cCAqLwo+ICAgCXJldCA9IHNkX3piY19zZXR1cChzZGtw LCB6b25lX2Jsb2Nrcyk7Cj4gClJlbWFpbmluZyBiaXRzIGFyZSBva2F5LgoKQ2hlZXJzLAoKSGFu bmVzCi0tIApEci4gSGFubmVzIFJlaW5lY2tlCQkgICBUZWFtbGVhZCBTdG9yYWdlICYgTmV0d29y a2luZwpoYXJlQHN1c2UuZGUJCQkgICAgICAgICAgICAgICArNDkgOTExIDc0MDUzIDY4OApTVVNF IExJTlVYIEdtYkgsIE1heGZlbGRzdHIuIDUsIDkwNDA5IE7DvHJuYmVyZwpHRjogRi4gSW1lbmTD tnJmZmVyLCBKLiBTbWl0aGFyZCwgSi4gR3VpbGQsIEQuIFVwbWFueXUsIEcuIE5vcnRvbgpIUkIg MjEyODQgKEFHIE7DvHJuYmVyZykKCi0tCmRtLWRldmVsIG1haWxpbmcgbGlzdApkbS1kZXZlbEBy ZWRoYXQuY29tCmh0dHBzOi8vd3d3LnJlZGhhdC5jb20vbWFpbG1hbi9saXN0aW5mby9kbS1kZXZl bA==