From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: [PATCH] dm: fix request-based dm's use of dm_wait_for_completion Date: Tue, 11 Dec 2018 07:40:22 -0700 Message-ID: References: <20181211141026.30174-1-snitzer@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20181211141026.30174-1-snitzer@redhat.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mike Snitzer Cc: linux-block@vger.kernel.org, dm-devel@redhat.com List-Id: dm-devel.ids On 12/11/18 7:10 AM, Mike Snitzer wrote: > The md->wait waitqueue is used by both bio-based and request-based DM. > Commit dbd3bbd291 ("dm rq: leverage blk_mq_queue_busy() to check for > outstanding IO") lost sight of the requirement that > dm_wait_for_completion() must work with all types of DM devices. > > Fix md_in_flight() to call the blk-mq or bio-based method accordingly. Applied, thanks. -- Jens Axboe