From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Damien Le Moal <damien.lemoal@wdc.com>,
dm-devel@redhat.com, Mike Snitzer <snitzer@redhat.com>,
linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [dm-devel] [PATCH v4 05/11] dm: cleanup device_area_is_invalid()
Date: Tue, 25 May 2021 14:10:10 -0500 [thread overview]
Message-ID: <fc584a3e-12f7-6ecb-1e38-98e69b93849f@oracle.com> (raw)
In-Reply-To: <20210525022539.119661-6-damien.lemoal@wdc.com>
On 5/24/21 9:25 PM, Damien Le Moal wrote:
> In device_area_is_invalid(), use bdev_is_zoned() instead of open
> coding the test on the zoned model returned by bdev_zoned_model().
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> ---
> drivers/md/dm-table.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index ee47a332b462..21fd9cd4da32 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c
> @@ -249,7 +249,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
> * If the target is mapped to zoned block device(s), check
> * that the zones are not partially mapped.
> */
> - if (bdev_zoned_model(bdev) != BLK_ZONED_NONE) {
> + if (bdev_is_zoned(bdev)) {
> unsigned int zone_sectors = bdev_zone_sectors(bdev);
>
> if (start & (zone_sectors - 1)) {
>
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
next prev parent reply other threads:[~2021-05-26 11:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 2:25 [dm-devel] [PATCH v4 00/11] dm: Improve zoned block device support Damien Le Moal
2021-05-25 2:25 ` [dm-devel] [PATCH v4 01/11] block: improve handling of all zones reset operation Damien Le Moal
2021-05-25 6:15 ` Chaitanya Kulkarni
2021-05-25 6:15 ` Chaitanya Kulkarni
2021-05-25 6:35 ` Damien Le Moal
2021-05-25 19:09 ` Himanshu Madhani
2021-05-25 2:25 ` [dm-devel] [PATCH v4 02/11] block: introduce bio zone helpers Damien Le Moal
2021-05-25 8:08 ` Christoph Hellwig
2021-05-25 19:09 ` Himanshu Madhani
2021-05-25 2:25 ` [dm-devel] [PATCH v4 03/11] block: introduce BIO_ZONE_WRITE_LOCKED bio flag Damien Le Moal
2021-05-25 19:09 ` Himanshu Madhani
2021-05-25 2:25 ` [dm-devel] [PATCH v4 04/11] dm: Fix dm_accept_partial_bio() Damien Le Moal
2021-05-25 8:12 ` Christoph Hellwig
2021-05-25 19:10 ` Himanshu Madhani
2021-05-25 2:25 ` [dm-devel] [PATCH v4 05/11] dm: cleanup device_area_is_invalid() Damien Le Moal
2021-05-25 8:13 ` Christoph Hellwig
2021-05-25 19:10 ` Himanshu Madhani [this message]
2021-05-25 2:25 ` [dm-devel] [PATCH v4 06/11] dm: move zone related code to dm-zone.c Damien Le Moal
2021-05-25 19:10 ` Himanshu Madhani
2021-05-25 2:25 ` [dm-devel] [PATCH v4 07/11] dm: Introduce dm_report_zones() Damien Le Moal
2021-05-25 19:11 ` Himanshu Madhani
2021-05-25 2:25 ` [dm-devel] [PATCH v4 08/11] dm: Forbid requeue of writes to zones Damien Le Moal
2021-05-25 19:13 ` Himanshu Madhani
2021-05-25 2:25 ` [dm-devel] [PATCH v4 09/11] dm: rearrange core declarations Damien Le Moal
2021-05-25 19:17 ` Himanshu Madhani
2021-05-25 2:25 ` [dm-devel] [PATCH v4 10/11] dm: introduce zone append emulation Damien Le Moal
2021-05-25 19:40 ` Himanshu Madhani
2021-05-25 2:25 ` [dm-devel] [PATCH v4 11/11] dm crypt: Fix zoned block device support Damien Le Moal
2021-05-25 19:44 ` Himanshu Madhani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc584a3e-12f7-6ecb-1e38-98e69b93849f@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@wdc.com \
--cc=dm-devel@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).