From: sashiko-bot@kernel.org
To: "Mikulas Patocka" <mpatocka@redhat.com>,
"Alasdair Kergon" <agk@redhat.com>,
"Mike Snitzer" <snitzer@kernel.org>,
"Benjamin Marzinski" <bmarzins@redhat.com>
Cc: dm-devel@lists.linux.dev
Subject: Re: [PATCH] dm persistent data: test return value of node_copy
Date: Fri, 06 Nov 2026 18:52:49 +0000 [thread overview]
Message-ID: <sashiko-outbox-202111@kernel.org> (raw)
In-Reply-To: <db8878fd-43c1-d976-debd-8e1d1547e7c7@redhat.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dm persistent data: Fixes trailer cites wrong commit for
node_copy()
--
commit f0758e03fa9ea11bfbf4ab38d82540be653f4f13
Author: Mikulas Patocka <mpatocka@redhat.com>
> dm persistent data: test return value of node_copy
>
> There were 3 places where the return value of node_copy was not tested.
>
> Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
> Assisted-by: Claude:claude-opus-5
> Cc: stable@vger.kernel.org
> Fixes: 3241b1d3e0aa ("dm: add persistent data library")
[Severity: Low]
In commit 3241b1d3e0aa ("dm: add persistent data library"), node_copy()
returned void and used BUG_ON() for error checks. Commit c671ffa55d8b
("dm btree remove: change a bunch of BUG_ON() calls to proper errors")
converted node_copy() to return an error code and left the three call
sites in __rebalance2() and delete_center_node() unchecked. Should the
Fixes tag be:
Fixes: c671ffa55d8b ("dm btree remove: change a bunch of BUG_ON() calls to proper errors")
--
Sashiko AI review · https://sashiko.dev/#/patchset/db8878fd-43c1-d976-debd-8e1d1547e7c7@redhat.com?part=1
prev parent reply other threads:[~2026-11-06 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 18:46 [PATCH] dm persistent data: test return value of node_copy Mikulas Patocka
2026-11-06 18:52 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-202111@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=agk@redhat.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=mpatocka@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox