From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Benjamin Marzinski <bmarzins@redhat.com>
Cc: "James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Mikulas Patocka <mpatocka@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
linux-scsi@vger.kernel.org, dm-devel@lists.linux.dev,
Martin Wilck <mwilck@suse.com>
Subject: Re: [PATCH v2] scsi: scsi_dh: Return error pointer in scsi_dh_attached_handler_name
Date: Mon, 08 Dec 2025 22:05:16 -0500 [thread overview]
Message-ID: <yq17buwpd80.fsf@ca-mkp.ca.oracle.com> (raw)
In-Reply-To: <20251206010015.1595225-1-bmarzins@redhat.com> (Benjamin Marzinski's message of "Fri, 5 Dec 2025 20:00:15 -0500")
Benjamin,
> If scsi_dh_attached_handler_name() fails to allocate the handler name,
> dm-multipath (its only caller) assumes there is no attached device
> handler, and sets the device up incorrectly. Return an error pointer
> instead, so multipath can distinguish between failure, success where
> there is no attached device handler, or when the path device is not a
> scsi device at all.
Applied to 6.19/scsi-staging, thanks!
--
Martin K. Petersen
prev parent reply other threads:[~2025-12-09 3:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-06 1:00 [PATCH v2] scsi: scsi_dh: Return error pointer in scsi_dh_attached_handler_name Benjamin Marzinski
2025-12-08 14:27 ` Martin Wilck
2025-12-09 3:05 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yq17buwpd80.fsf@ca-mkp.ca.oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=bmarzins@redhat.com \
--cc=dm-devel@lists.linux.dev \
--cc=linux-scsi@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=mwilck@suse.com \
--cc=snitzer@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox