From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Martin K. Petersen" Subject: Re: [PATCH] block: Require subsystems to explicitly allocate bio_set integrity mempool Date: Fri, 11 Mar 2011 12:11:55 -0500 Message-ID: References: <20110228131028.GB3626@agk-dp.fab.redhat.com> <4D6BA566.1050305@redhat.com> <4D73F104.2050807@redhat.com> <20110307160914.GA29697@redhat.com> <20110308171322.GB5692@redhat.com> <20110311165305.GA28769@redhat.com> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20110311165305.GA28769@redhat.com> (Mike Snitzer's message of "Fri, 11 Mar 2011 11:53:05 -0500") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Mike Snitzer Cc: Jens Axboe , device-mapper development , "Martin K. Petersen" , Zdenek Kabelac List-Id: dm-devel.ids >>>>> "Mike" == Mike Snitzer writes: >> Yeah, that'll come as part of my DIX1.1 patch set. Mike> Seems my concern should be fixed independent of a larger update Mike> patchset. Unless DIX isn't meaningful for "stable" kernels Mike> without your full DIX1.1 update? Well, I'm not aware of any shipping non-512 byte block DIF devices other than scsi_debug. And it's not good enough to just fix it in DM since this is a hardware parameter that needs to be queried and bubbled up. It can't be scaled like the rest of the topology block sizes, it's wired in the hardware. So I just don't see much point in trying to fix it now when any ties to the logical block size will be severed in my impending patch set. -- Martin K. Petersen Oracle Linux Engineering