From: Lars-Peter Clausen <lars@metafoo.de>
To: Cai Huoqing <cai.huoqing@linux.dev>, fancer.lancer@gmail.com
Cc: "Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Vinod Koul" <vkoul@kernel.org>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v7 3/5] dmaengine: dw-edma: Add support for native HDMA
Date: Sat, 18 Mar 2023 06:49:41 -0700 [thread overview]
Message-ID: <02216197-6cbd-319d-1015-bfb4449ead85@metafoo.de> (raw)
In-Reply-To: <20230315012840.6986-4-cai.huoqing@linux.dev>
On 3/14/23 18:28, Cai Huoqing wrote:
> Add support for HDMA NATIVE, as long the IP design has set
>
> diff --git a/drivers/dma/dw-edma/dw-hdma-v0-regs.h b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> new file mode 100644
> index 000000000000..0a6032aa1a33
> --- /dev/null
> +++ b/drivers/dma/dw-edma/dw-hdma-v0-regs.h
> @@ -0,0 +1,130 @@
>
> +struct dw_hdma_v0_ch_regs {
> [...]
> + u32 msi_msgdata; /* 0x00a8 */
> + u32 padding_2[21]; /* 0x00ac..0x00e8 */
The comment here is wrong. This goes all the way to 0x00fc.
> +} __packed;
> +
next prev parent reply other threads:[~2023-03-18 14:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 1:28 [PATCH v7 0/5] dmaengine: dw-edma: Add support for native HDMA Cai Huoqing
2023-03-15 1:28 ` [PATCH v7 1/5] dmaengine: dw-edma: Rename dw_edma_core_ops structure to dw_edma_plat_ops Cai Huoqing
2023-03-15 1:28 ` [PATCH v7 2/5] dmaengine: dw-edma: Create a new dw_edma_core_ops structure to abstract controller operation Cai Huoqing
2023-03-20 11:09 ` Serge Semin
2023-03-15 1:28 ` [PATCH v7 3/5] dmaengine: dw-edma: Add support for native HDMA Cai Huoqing
2023-03-18 13:49 ` Lars-Peter Clausen [this message]
2023-03-20 2:36 ` Cai Huoqing
2023-03-20 2:39 ` Cai Huoqing
2023-03-20 11:37 ` Serge Semin
2023-03-15 1:28 ` [PATCH v7 4/5] dmaengine: dw-edma: Add HDMA DebugFS support Cai Huoqing
2023-03-20 11:53 ` Serge Semin
2023-03-22 3:17 ` Cai Huoqing
2023-03-22 5:44 ` Serge Semin
2023-03-15 1:28 ` [PATCH v7 5/5] dmaengine: dw-edma: Optimization in dw_edma_v0_core_handle_int Cai Huoqing
2023-03-20 12:14 ` [PATCH v7 0/5] dmaengine: dw-edma: Add support for native HDMA Serge Semin
2023-03-21 2:31 ` Cai Huoqing
2023-03-21 8:34 ` Serge Semin
2023-03-21 12:21 ` Cai Huoqing
2023-03-21 19:39 ` Serge Semin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02216197-6cbd-319d-1015-bfb4449ead85@metafoo.de \
--to=lars@metafoo.de \
--cc=bhelgaas@google.com \
--cc=cai.huoqing@linux.dev \
--cc=dmaengine@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox