From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Michal Simek <michal.simek@amd.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu,
michal.simek@xilinx.com, git@xilinx.com,
Hyun Kwon <hyun.kwon@xilinx.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>, Vinod Koul <vkoul@kernel.org>,
devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] dt-bindings: dma: xilinx: Add power-domains to xlnx,zynqmp-dpdma
Date: Wed, 3 May 2023 16:09:34 +0200 [thread overview]
Message-ID: <0537e5be-87c3-c551-ac12-d2cdf5b18b07@linaro.org> (raw)
In-Reply-To: <a5ff9c0f-6ee9-8b1a-5f77-fb56176bce22@amd.com>
On 03/05/2023 15:27, Michal Simek wrote:
> Hi,
>
> On 5/3/23 14:51, Laurent Pinchart wrote:
>> Hi Michal,
>>
>> Thank you for the patch.
>>
>> On Wed, May 03, 2023 at 10:00:20AM +0200, Michal Simek wrote:
>>> DP DMA has own power domain that's why describe optional power-domain
>>> property.
>>
>> As far as I understand, the property should always be specified, the
>> only reason why it's not mandatory is backward-compatibility (I would
>> make it mandatory, as I think proper validation of new DT is more
>> important than avoiding breaking validation - but not operation! - of
>> old DT, but that's a separate story). If my understanding is correct,
>> could you please update the example in the bindings to add the
>> power-domains property ?
>
> backward compatible - of course
> always specified - if pd driver is enabled it must be there. If not it doesn't
> do anything - just describes it.
>
> I am not in a position to decide this. But if dt folks agree with your ask I am
> happy to make it mandatory and extend example.
By making it mandatory in the bindings only, not in the driver, no real
ABI gets broken. Linux won't stop booting if property is missing.
Therefore if device is always part of power domain and it is actually
required, then sure - making it required is useful.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-05-03 14:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-03 8:00 [PATCH v2] dt-bindings: dma: xilinx: Add power-domains to xlnx,zynqmp-dpdma Michal Simek
2023-05-03 8:06 ` Krzysztof Kozlowski
2023-05-03 12:51 ` Laurent Pinchart
2023-05-03 13:27 ` Michal Simek
2023-05-03 14:09 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0537e5be-87c3-c551-ac12-d2cdf5b18b07@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=git@xilinx.com \
--cc=hyun.kwon@xilinx.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=michal.simek@xilinx.com \
--cc=monstr@monstr.eu \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox