From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D62D9312821 for ; Mon, 13 Oct 2025 15:41:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760370070; cv=none; b=EKZQbshLXRr6t7erMOcv6kpSJAT1NLTqTFDZYMISzyvbnw7Jne6ip7JuP3aKVQiR8NlP5i6/e3fYw0Rp7ufRT2YKgfayp14SmlTRx38Aej9JjPazga+CGAxPvD63lypahmtqODLgMYNk64MxW1QtyjcETE5k9dEq6fYyGMQMDf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760370070; c=relaxed/simple; bh=ZNGpwN1spmmQtLYHgY9XQ8MI4uywOHGxkDfxDwlS9Cw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=BqQz+H1Lv29cd5wyA/KuzZKJs9sgqa7OIVAn3C/4kBlhSTeWz3k1Sqh8B5HH/473OOTmz930N9QgjdkFX8ntkUAuvU/HbNHlAtzOdIrS7YztF+EmTvNxhHo/GYrbHmsz3MDQQgzU5Y//JPiIGVpbUaYJfLAImaLyxP15Un+U+rA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1v8KfX-0003C1-Vd; Mon, 13 Oct 2025 17:41:03 +0200 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1v8KfX-003PMz-00; Mon, 13 Oct 2025 17:41:03 +0200 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1v8KfW-00000000DI9-3soz; Mon, 13 Oct 2025 17:41:02 +0200 Message-ID: <06e7f7f23fb264e9db39441698b33c048d8192e3.camel@pengutronix.de> Subject: Re: [PATCH 2/2] dmaengine: dw-axi-dmac: add reset control support From: Philipp Zabel To: Artem Shimko Cc: Eugeniy Paltsev , Vinod Koul , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 13 Oct 2025 17:41:02 +0200 In-Reply-To: References: <20251012100002.2959213-1-a.shimko.dev@gmail.com> <20251012100002.2959213-3-a.shimko.dev@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.1-1 Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dmaengine@vger.kernel.org On Mo, 2025-10-13 at 17:56 +0300, Artem Shimko wrote: [...] > dw_remove() has axi_dma_suspend() function, which is where the reset asse= rtion > occurs via reset_control_assert(). It looks to me like dw_remove() is now missing a deassert before accessing registers, in case the device is removed while runtime suspended. regards Philipp