From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 177D11A0BD0; Fri, 29 Aug 2025 10:44:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756464270; cv=none; b=BPAmlX6cZBq/kImeuMaYNuUq/dQoB0pu6wSoqYi5cIt0NPn7pb5jY/nQBFpoLycTfoBoi0T+PSj2pWYwZxVyVkYL5OCNhJEstWfXmcqjayDAQCH1PoMHY73N3R9zzQSU9rK0x9IyjpwHAx5LJU2b8DpsEFkOCP4fOU8OKW2dKd0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1756464270; c=relaxed/simple; bh=7al6VARdCJBqhLhxUw7t39dmdFpKaU88KDVc0vncB/Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=p5dy1a3uSn81CEec00sfrTENgCr02SuZDx33beSJr9FgcZJbjU1Y0Ev60jCL+C32u/70t7W3Dyl9bylJ9wlqvR8xWoOB+71Qvm7GSyDum5Gx8Ft/MyIWXOjG8GXihl/92Is5b+HDu5aHTopRTV7VfAtVqTJ4DjVbzZsfImhEZh4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 09BEB1758; Fri, 29 Aug 2025 03:44:20 -0700 (PDT) Received: from [10.57.2.173] (unknown [10.57.2.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F0BB53F694; Fri, 29 Aug 2025 03:44:25 -0700 (PDT) Message-ID: <097a3e2e-202e-4f4c-b981-69156aeca051@arm.com> Date: Fri, 29 Aug 2025 11:44:23 +0100 Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/14] dmaengine: dma350: Fix CH_CTRL_USESRCTRIGIN definition To: Jisheng Zhang , Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: dmaengine@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250823154009.25992-1-jszhang@kernel.org> <20250823154009.25992-2-jszhang@kernel.org> From: Robin Murphy Content-Language: en-GB In-Reply-To: <20250823154009.25992-2-jszhang@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2025-08-23 4:39 pm, Jisheng Zhang wrote: > Per the arm-dma350 TRM, The CH_CTRL_USESRCTRIGIN is BIT(25). Oops! Reviewed-by: Robin Murphy > Signed-off-by: Jisheng Zhang > --- > drivers/dma/arm-dma350.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/dma/arm-dma350.c b/drivers/dma/arm-dma350.c > index 9efe2ca7d5ec..bf3962f00650 100644 > --- a/drivers/dma/arm-dma350.c > +++ b/drivers/dma/arm-dma350.c > @@ -58,7 +58,7 @@ > > #define CH_CTRL 0x0c > #define CH_CTRL_USEDESTRIGIN BIT(26) > -#define CH_CTRL_USESRCTRIGIN BIT(26) > +#define CH_CTRL_USESRCTRIGIN BIT(25) > #define CH_CTRL_DONETYPE GENMASK(23, 21) > #define CH_CTRL_REGRELOADTYPE GENMASK(20, 18) > #define CH_CTRL_XTYPE GENMASK(11, 9)