From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bhupesh Sharma <bhupesh.sharma@linaro.org>,
dmaengine@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Cc: agross@kernel.org, linux-kernel@vger.kernel.org,
andersson@kernel.org, bhupesh.linux@gmail.com, vkoul@kernel.org,
krzysztof.kozlowski@linaro.org, robh+dt@kernel.org,
vladimir.zapolskiy@linaro.org
Subject: Re: [PATCH 2/2] dmaengine: qcom: bam_dma: Add support for BAM engine v1.7.4
Date: Mon, 20 Mar 2023 11:42:04 +0100 [thread overview]
Message-ID: <0a8fcd57-94dc-61e6-0ba0-b1591e05e6f2@linaro.org> (raw)
In-Reply-To: <20230320071211.3005769-2-bhupesh.sharma@linaro.org>
On 20.03.2023 08:12, Bhupesh Sharma wrote:
> Qualcomm SoCs SM6115 and QRB2290 support BAM engine version
> v1.7.4.
>
> Add the support for the same in driver. Since the reg info of
> this version is similar to version v1.7.0, so reuse the same.
>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> drivers/dma/qcom/bam_dma.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/qcom/bam_dma.c b/drivers/dma/qcom/bam_dma.c
> index 1e47d27e1f81..153d189de7d2 100644
> --- a/drivers/dma/qcom/bam_dma.c
> +++ b/drivers/dma/qcom/bam_dma.c
> @@ -1228,6 +1228,7 @@ static const struct of_device_id bam_of_match[] = {
> { .compatible = "qcom,bam-v1.3.0", .data = &bam_v1_3_reg_info },
> { .compatible = "qcom,bam-v1.4.0", .data = &bam_v1_4_reg_info },
> { .compatible = "qcom,bam-v1.7.0", .data = &bam_v1_7_reg_info },
> + { .compatible = "qcom,bam-v1.7.4", .data = &bam_v1_7_reg_info },
The compatible is meaningless as of today (it uses the exact same driver
data as v1.7.0), so I'd say going with:
compatible = "qcom,bam-v1.7.4", "qcom,bam-v1.7.0";
is what we want.
Konrad
> {}
> };
>
next prev parent reply other threads:[~2023-03-20 10:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 7:12 [PATCH 1/2] dt-bindings: dma: Add support for SM6115 and QCS2290 SoCs Bhupesh Sharma
2023-03-20 7:12 ` [PATCH 2/2] dmaengine: qcom: bam_dma: Add support for BAM engine v1.7.4 Bhupesh Sharma
2023-03-20 10:42 ` Konrad Dybcio [this message]
2023-03-21 6:34 ` Bhupesh Sharma
2023-03-24 12:08 ` [PATCH 1/2] dt-bindings: dma: Add support for SM6115 and QCS2290 SoCs Vladimir Zapolskiy
2023-03-28 5:53 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a8fcd57-94dc-61e6-0ba0-b1591e05e6f2@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bhupesh.sharma@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox