Re: [RFC 3/3] dmaengine: Support for requesting channels preferring DMA domain controller

Vinod Koul
2019-09-12T16:50:51Z

On 09-09-19, 08:56, Peter Ujfalusi wrote:

> >> -struct dma_chan *dma_request_chan_by_mask(const dma_cap_mask_t *mask)
> >> +struct dma_chan *dma_domain_request_chan_by_mask(struct device *dev,
> >> + const dma_cap_mask_t *mask)
> >
> > should we really use dma_request_chan_by_mask() why not create a new api
> > dma_request_chan_by_domain() and use that, it falls back to
> > dma_request_chan_by_mask() if it doesnt find a valid domain!
>
> So:
> struct dma_chan *dma_request_chan_by_domain(struct device *dev,
> const dma_cap_mask_t *mask);

Yeah that looks better to me :)

--
~Vinod