From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com [209.85.221.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4556279DB6 for ; Mon, 20 Oct 2025 17:49:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760982580; cv=none; b=j7S7sUcLxhcgVbztRVhAEVTQkB8ziQT7faJI+kIaGHBhHCruQZvb+CEQoiaa4LSBsou8xCGTIhE6S2Abhk/fJdomHmVUm300daOxN92GjD2BQsddnMOjUVYBk27HLkYksUl4t+B/GWATfStZQNzTc87sfG8GacnTGjiPOtzAwng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760982580; c=relaxed/simple; bh=xOrPsbGqKSS2XyeFNV4ELqt4UHoe2WbEgpv+4VqM/Is=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Se+8DOIFyy258Qgt7Rpbu64m7iZCxIgx+NGXN4zCK05AevrPgK0wyGCabPcgE5dfbTNf6a3dSxj7Rgfd/SdTtFzzsd7PILtd3T4SZC6F927P3YDxqS6gwfPKqYh/vw9GegRh0itSre6JLsgF+6mRlMsIkDHRfdufAm0ta6YkSjY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=K25zH5y9; arc=none smtp.client-ip=209.85.221.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="K25zH5y9" Received: by mail-wr1-f41.google.com with SMTP id ffacd0b85a97d-3ee64bc6b85so6342828f8f.3 for ; Mon, 20 Oct 2025 10:49:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760982576; x=1761587376; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uyCd/4JIj55gxSeGf4+DJdNpJNeCwDGuxusuHQkGxZw=; b=K25zH5y9ffuiLrCpG3kE75L6TD3muWG3iAtqc/uKRp9OgpBCF1azYj2g+/3k/TS73M PNgXCpiR+3LGrZ0XPTgrwJ3KS/sy2BF2HL1UK6ikQWBK48LTLo+MX0/mXd6SJwV4KB1v kLoL2GEhPcn+2qKR8dBZpD0mZMngY5bVuvCVrpJ2hcIV9CI1xhHONt/54DXdz/RbKowe P6u7IA9DcqrpA8hd3fIf15IrreZ8S6gr6Jk+ikv/fFMljRqOrf11adHr6jwYPJtYDO1f krhrxSjZpeWM0f2jaDTJN+3iJYJbLVfnP7J5YSgaJvmuOXpS10qbnQmyfZ95a6OgCN4V vuWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760982576; x=1761587376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uyCd/4JIj55gxSeGf4+DJdNpJNeCwDGuxusuHQkGxZw=; b=mBcDtVkvpcSkdXk0/xy+KgrPizm12V1lNahdR9rD04HfmeUrxV+SdrMpUQtwV+IvqQ 8XbSOOfOZ8g+QWZPAWplEiGEyKcpQk8co5uGY5oUP8xcFdr7EJ1FYw+NWKH3b7i+WKv7 Nqs2/zwtvmrrf+EnYKP08y+dIJfND7lexlesp1NUKvfpaR0jIKsjArbWpO41Mm2azL+g gl+I4KEFdYSPNPPMM/qmItUBWECjc1eM92gEqCJyZf3A4nrdJMwd7bV3EZpvKEfxSHQk VoV5GNdfilcKrzs94u4fe4tQsoh2NKQfcQ9z6dVW+ubkLf12Gp0bPeiK0N9g5Uf/kmej IAow== X-Forwarded-Encrypted: i=1; AJvYcCVIE/b3OuVRTzeCIJPdTWTtMJ4Y7TZcj16IR+qVqDCAgp/HFI0TGaAeIQVIboQ8PRQ1mAkNT47Liyo=@vger.kernel.org X-Gm-Message-State: AOJu0YwrTbD0crvMMuILjaUwLe28HY1Zs5oCyKyK9B39qSAc9h8vj5zp MEKKKXYEiMjihOqMrGo3kKHDBuzC1iGo4Em93DhOXQTv/DzQWXZ1pr6UkwN90w== X-Gm-Gg: ASbGnctZeStItOobY0ym1G9pQFqy61fEqTljMaOlt6dKf/27sTccFva5dqGqE7q3JqM H6/ZpBDxsU5WiHB717y8kuQ2TsK5SuDQzpFrzvaJdgWwCwzG9LJsVk4+nGccF9kiWYpaMXWVs2C //Uc8XdnlA+tlK/8Oy60jlbv8MarOM2tXdKWHWnM4zfLFn+y/D5EoTxxTs+6wM7yj0zlDH+VZvf n63+/hJuMIPqzdiTYRhjMBXTA+mlMjiDWm9BhPxlcggIeeai1fnAqmuWeXpGcSFrmkkFObdYmWp QTHJ1z2ZxgsNoz5xPFVHl/PdfygHX6ozJ9xxgJOk5j6lxnmxd2LUoZPQYhebTGQiOFrG4VURHto mwE8Ug7GPTSyE2eJQzYZfXsdzZqts9ZEZwcnqFytSt+jYylBuzd1nA9MG+Z9y1kBkQup4T/EDTH QxWOI437TmIfP7/h/XuwfsVBWTQzE7M4klIa8rEbQIVgAGs0RwNf+YODPkCa2P1jKwmBngDquht NN0nA== X-Google-Smtp-Source: AGHT+IFVJfltDBGpXshwdA6ycK/H046cTrEtcv4sm/ksCoAaIUW3ZG+YpLxzBGC+3OrZRm/196984w== X-Received: by 2002:a05:6000:4021:b0:427:8b:441a with SMTP id ffacd0b85a97d-42704d7e960mr9407198f8f.11.1760982575740; Mon, 20 Oct 2025 10:49:35 -0700 (PDT) Received: from jernej-laptop.localnet (178-79-73-218.dynamic.telemach.net. [178.79.73.218]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-427ea5b3c34sm16212597f8f.17.2025.10.20.10.49.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Oct 2025 10:49:35 -0700 (PDT) From: Jernej =?UTF-8?B?xaBrcmFiZWM=?= To: Chen-Yu Tsai , Jernej Skrabec , Samuel Holland , Mark Brown , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vinod Koul , Chen-Yu Tsai Cc: linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/11] ASoC: sun4i-spdif: Support SPDIF output on A523 family Date: Mon, 20 Oct 2025 19:49:34 +0200 Message-ID: <13867454.uLZWGnKmhe@jernej-laptop> In-Reply-To: <20251020171059.2786070-5-wens@kernel.org> References: <20251020171059.2786070-1-wens@kernel.org> <20251020171059.2786070-5-wens@kernel.org> Precedence: bulk X-Mailing-List: dmaengine@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Hi, Dne ponedeljek, 20. oktober 2025 ob 19:10:50 Srednjeevropski poletni =C4=8D= as je Chen-Yu Tsai napisal(a): > The TX side of the SPDIF block on the A523 is almost the same the > previous generations, the only difference being that it has separate > module clock inputs for the TX and RX side. >=20 > Since this driver currently only supports TX, add support for a > different clock name so that TX and RX clocks can be separated > if RX support is ever added. Then add support for the A523. >=20 > Signed-off-by: Chen-Yu Tsai > --- > sound/soc/sunxi/sun4i-spdif.c | 28 +++++++++++++++++++++++++--- > 1 file changed, 25 insertions(+), 3 deletions(-) >=20 > diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c > index 34e5bd94e9af..6a58dc4311de 100644 > --- a/sound/soc/sunxi/sun4i-spdif.c > +++ b/sound/soc/sunxi/sun4i-spdif.c > @@ -177,6 +177,7 @@ struct sun4i_spdif_quirks { > bool has_reset; > unsigned int val_fctl_ftx; > unsigned int mclk_multiplier; > + const char *tx_clk_name; > }; > =20 > struct sun4i_spdif_dev { > @@ -323,6 +324,7 @@ static int sun4i_spdif_hw_params(struct snd_pcm_subst= ream *substream, > } > mclk *=3D host->quirks->mclk_multiplier; > =20 > + dev_info(&pdev->dev, "Setting SPDIF clock rate to %u\n", mclk); > ret =3D clk_set_rate(host->spdif_clk, mclk); > if (ret < 0) { > dev_err(&pdev->dev, > @@ -542,7 +544,6 @@ static struct snd_soc_dai_driver sun4i_spdif_dai =3D { > .formats =3D SUN4I_FORMATS, > }, > .ops =3D &sun4i_spdif_dai_ops, > - .name =3D "spdif", Why this change? > }; > =20 > static const struct sun4i_spdif_quirks sun4i_a10_spdif_quirks =3D { > @@ -572,6 +573,14 @@ static const struct sun4i_spdif_quirks sun50i_h6_spd= if_quirks =3D { > .mclk_multiplier =3D 1, > }; > =20 > +static const struct sun4i_spdif_quirks sun55i_a523_spdif_quirks =3D { > + .reg_dac_txdata =3D SUN8I_SPDIF_TXFIFO, > + .val_fctl_ftx =3D SUN50I_H6_SPDIF_FCTL_FTX, > + .has_reset =3D true, > + .mclk_multiplier =3D 1, > + .tx_clk_name =3D "tx", > +}; > + > static const struct of_device_id sun4i_spdif_of_match[] =3D { > { > .compatible =3D "allwinner,sun4i-a10-spdif", > @@ -594,6 +603,15 @@ static const struct of_device_id sun4i_spdif_of_matc= h[] =3D { > /* Essentially the same as the H6, but without RX */ > .data =3D &sun50i_h6_spdif_quirks, > }, > + { > + .compatible =3D "allwinner,sun55i-a523-spdif", > + /* > + * Almost the same as H6, but has split the TX and RX clocks, > + * has a separate reset bit for the RX side, and has some > + * expanded features for the RX side. > + */ > + .data =3D &sun55i_a523_spdif_quirks, > + }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, sun4i_spdif_of_match); > @@ -635,6 +653,7 @@ static int sun4i_spdif_probe(struct platform_device *= pdev) > const struct sun4i_spdif_quirks *quirks; > int ret; > void __iomem *base; > + const char *tx_clk_name =3D "spdif"; Reverse tree? Otherwise it looks good. Best regards, Jernej > =20 > dev_dbg(&pdev->dev, "Entered %s\n", __func__); > =20 > @@ -671,9 +690,12 @@ static int sun4i_spdif_probe(struct platform_device = *pdev) > return PTR_ERR(host->apb_clk); > } > =20 > - host->spdif_clk =3D devm_clk_get(&pdev->dev, "spdif"); > + if (quirks->tx_clk_name) > + tx_clk_name =3D quirks->tx_clk_name; > + host->spdif_clk =3D devm_clk_get(&pdev->dev, tx_clk_name); > if (IS_ERR(host->spdif_clk)) { > - dev_err(&pdev->dev, "failed to get a spdif clock.\n"); > + dev_err(&pdev->dev, "failed to get the \"%s\" clock.\n", > + tx_clk_name); > return PTR_ERR(host->spdif_clk); > } > =20 >=20