From: venkat.prashanth2498@gmail.com
To: vinod.koul@intel.com, dan.j.williams@intel.com
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
Subject: DMA:omap-dma: Fix kernel compilation error and checkpatch issues
Date: Mon, 11 Dec 2017 19:30:33 +0530 [thread overview]
Message-ID: <1513000833-17514-1-git-send-email-venkat.prashanth2498@gmail.com> (raw)
From: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
This is the patch to the omap-dma.c file that fixes
the following issues:
1.redefinition of 'omap_dma_filter_fn' in the line 1273
of drivers/dma/omap-dma.c
2.drivers/dma/omap-dma.c:341: ERROR: code indent should
use tabs where possible reported by ./checkpatch.pl
3.drivers/dma/omap-dma.c:749: WARNING: Missing a blank
line after declarations reported by ./checkpatch.pl
Signed-off-by: Venkat Prashanth B U <venkat.prashanth2498@gmail.com>
---
drivers/dma/omap-dma.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/omap-dma.c b/drivers/dma/omap-dma.c
index 1dfc71c..2a40485 100644
--- a/drivers/dma/omap-dma.c
+++ b/drivers/dma/omap-dma.c
@@ -338,7 +338,7 @@ static void omap_dma_stop(struct omap_chan *c)
if (val & (CCR_RD_ACTIVE | CCR_WR_ACTIVE))
dev_err(c->vc.chan.device->dev,
"DMA drain did not complete on lch %d\n",
- c->dma_ch);
+ c->dma_ch);
omap_dma_glbl_write(od, OCP_SYSCONFIG, sysconfig);
} else {
@@ -746,6 +746,7 @@ static void omap_dma_issue_pending(struct dma_chan *chan)
*/
if (!c->cyclic) {
struct omap_dmadev *d = to_omap_dma_dev(chan->device);
+
spin_lock(&d->lock);
if (list_empty(&c->node))
list_add_tail(&c->node, &d->pending);
@@ -1269,7 +1270,7 @@ static struct platform_driver omap_dma_driver = {
},
};
-bool omap_dma_filter_fn(struct dma_chan *chan, void *param)
+bool omap_dma_filter_func(struct dma_chan *chan, void *param)
{
if (chan->device->dev->driver == &omap_dma_driver.driver) {
struct omap_dmadev *od = to_omap_dma_dev(chan->device);
next reply other threads:[~2017-12-11 14:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 14:00 venkat.prashanth2498 [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-11 16:41 DMA:omap-dma: Fix kernel compilation error and checkpatch issues Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1513000833-17514-1-git-send-email-venkat.prashanth2498@gmail.com \
--to=venkat.prashanth2498@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).