* dmaengine: sprd: statify 'sprd_dma_prep_dma_memcpy'
@ 2018-01-12 17:08 Vinod Koul
0 siblings, 0 replies; 2+ messages in thread
From: Vinod Koul @ 2018-01-12 17:08 UTC (permalink / raw)
To: dmaengine; +Cc: baolin.wang, Vinod Koul
Sparse warns that 'sprd_dma_prep_dma_memcpy' should be static so make it
static.
drivers/dma/sprd-dma.c:713:32: warning:
symbol'sprd_dma_prep_dma_memcpy' was not declared. Should it be static?
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
drivers/dma/sprd-dma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
index b652071a2096..b106e8a60af6 100644
--- a/drivers/dma/sprd-dma.c
+++ b/drivers/dma/sprd-dma.c
@@ -710,7 +710,7 @@ static int sprd_dma_config(struct dma_chan *chan, struct sprd_dma_desc *sdesc,
return 0;
}
-struct dma_async_tx_descriptor *
+static struct dma_async_tx_descriptor *
sprd_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
size_t len, unsigned long flags)
{
^ permalink raw reply related [flat|nested] 2+ messages in thread
* dmaengine: sprd: statify 'sprd_dma_prep_dma_memcpy'
@ 2018-01-15 2:15 Baolin Wang
0 siblings, 0 replies; 2+ messages in thread
From: Baolin Wang @ 2018-01-15 2:15 UTC (permalink / raw)
To: Vinod Koul; +Cc: dmaengine, Baolin Wang
Hi Vinod,
On 13 January 2018 at 01:08, Vinod Koul <vinod.koul@intel.com> wrote:
> Sparse warns that 'sprd_dma_prep_dma_memcpy' should be static so make it
> static.
>
> drivers/dma/sprd-dma.c:713:32: warning:
> symbol'sprd_dma_prep_dma_memcpy' was not declared. Should it be static?
>
> Signed-off-by: Vinod Koul <vinod.koul@intel.com>
Thanks for fixing my mistake.
Reviewed-by: Baolin Wang <baolin.wang@linaro.org>
> ---
> drivers/dma/sprd-dma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c
> index b652071a2096..b106e8a60af6 100644
> --- a/drivers/dma/sprd-dma.c
> +++ b/drivers/dma/sprd-dma.c
> @@ -710,7 +710,7 @@ static int sprd_dma_config(struct dma_chan *chan, struct sprd_dma_desc *sdesc,
> return 0;
> }
>
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
> sprd_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest, dma_addr_t src,
> size_t len, unsigned long flags)
> {
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-15 2:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-12 17:08 dmaengine: sprd: statify 'sprd_dma_prep_dma_memcpy' Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-01-15 2:15 Baolin Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).