[1/3] dmaengine: imx-sdma: Switch to SPDX identifier

[1/3] dmaengine: imx-sdma: Switch to SPDX identifier

[Fabio Estevam]

From: Fabio Estevam <fabio.estevam@nxp.com>

Adopt the SPDX license identifier headers to ease license compliance
management.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 drivers/dma/imx-sdma.c | 29 +++++++++++------------------
 1 file changed, 11 insertions(+), 18 deletions(-)

diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index ccd03c3..f0779926 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1,21 +1,14 @@
-/*
- * drivers/dma/imx-sdma.c
- *
- * This file contains a driver for the Freescale Smart DMA engine
- *
- * Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>
- *
- * Based on code from Freescale:
- *
- * Copyright 2004-2009 Freescale Semiconductor, Inc. All Rights Reserved.
- *
- * The code contained herein is licensed under the GNU General Public
- * License. You may obtain a copy of the GNU General Public License
- * Version 2 or later at the following locations:
- *
- * http://www.opensource.org/licenses/gpl-license.html
- * http://www.gnu.org/copyleft/gpl.html
- */
+// SPDX-License-Identifier: GPL-2.0+
+//
+// drivers/dma/imx-sdma.c
+//
+// This file contains a driver for the Freescale Smart DMA engine
+//
+// Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>
+//
+// Based on code from Freescale:
+//
+// Copyright 2004-2009 Freescale Semiconductor, Inc. All Rights Reserved.
 
 #include <linux/init.h>
 #include <linux/iopoll.h>

[1/3] dmaengine: imx-sdma: Switch to SPDX identifier

[Vinod Koul]

On 21-05-18, 23:53, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Adopt the SPDX license identifier headers to ease license compliance
> management.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/dma/imx-sdma.c | 29 +++++++++++------------------
>  1 file changed, 11 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index ccd03c3..f0779926 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1,21 +1,14 @@
> -/*
> - * drivers/dma/imx-sdma.c
> - *
> - * This file contains a driver for the Freescale Smart DMA engine
> - *
> - * Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>
> - *
> - * Based on code from Freescale:
> - *
> - * Copyright 2004-2009 Freescale Semiconductor, Inc. All Rights Reserved.
> - *
> - * The code contained herein is licensed under the GNU General Public
> - * License. You may obtain a copy of the GNU General Public License
> - * Version 2 or later at the following locations:
> - *
> - * http://www.opensource.org/licenses/gpl-license.html
> - * http://www.gnu.org/copyleft/gpl.html
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +//
> +// drivers/dma/imx-sdma.c
> +//
> +// This file contains a driver for the Freescale Smart DMA engine
> +//
> +// Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>
> +//
> +// Based on code from Freescale:
> +//
> +// Copyright 2004-2009 Freescale Semiconductor, Inc. All Rights Reserved.

Are you sure putting everything thru c99 style is apt. I have been told that we
should:

// SPDX-License-Identifier: GPL-2.0+
// Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>

/*
 * rest of the comments you would like
 */

essentially SPDX tag and copyright should be c99 so that tools can parse, rest
information can be in regular linux comment style

[1/3] dmaengine: imx-sdma: Switch to SPDX identifier

[Fabio Estevam]

Hi Vinod,

On Tue, May 22, 2018 at 12:36 AM, Vinod Koul <vinod.koul@linaro.org> wrote:

> Are you sure putting everything thru c99 style is apt. I have been told that we
> should:
>
> // SPDX-License-Identifier: GPL-2.0+
> // Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>
>
> /*
>  * rest of the comments you would like
>  */
>
> essentially SPDX tag and copyright should be c99 so that tools can parse, rest
> information can be in regular linux comment style

Putting everything as // is Linus' preferred style:
https://lkml.org/lkml/2017/11/25/133
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[1/3] dmaengine: imx-sdma: Switch to SPDX identifier

[Vinod Koul]

On 22-05-18, 08:22, Fabio Estevam wrote:
> Hi Vinod,
> 
> On Tue, May 22, 2018 at 12:36 AM, Vinod Koul <vinod.koul@linaro.org> wrote:
> 
> > Are you sure putting everything thru c99 style is apt. I have been told that we
> > should:
> >
> > // SPDX-License-Identifier: GPL-2.0+
> > // Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>
> >
> > /*
> >  * rest of the comments you would like
> >  */
> >
> > essentially SPDX tag and copyright should be c99 so that tools can parse, rest
> > information can be in regular linux comment style
> 
> Putting everything as // is Linus' preferred style:
> https://lkml.org/lkml/2017/11/25/133

Sadly it is not documented, only SPDX tags are in
Documentation/process/license-rules.rst

[1/3] dmaengine: imx-sdma: Switch to SPDX identifier

[Vinod Koul]

On 21-05-18, 23:53, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Adopt the SPDX license identifier headers to ease license compliance
> management.

Applied all, thanks