From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v2] mfd: intel-lpss: Set the device in reset state when init From: Binbin Wu Message-Id: <1554710950-21212-1-git-send-email-binbin.wu@intel.com> Date: Mon, 8 Apr 2019 16:09:10 +0800 To: rjw@rjwysocki.net, linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, lee.jones@linaro.org, mika.westerberg@linux.intel.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, andriy.shevchenko@linux.intel.com Cc: binbin.wu@intel.com List-ID: SW4gdmlydHVhbGl6ZWQgc2V0dXAsIHdoZW4gc3lzdGVtIHJlYm9vdHMgZHVlIHRvIHdhcm0KcmVz ZXQgaW50ZXJydXB0IHN0b3JtIGlzIHNlZW4uCgpDYWxsIFRyYWNlOgo8SVJRPgpkdW1wX3N0YWNr KzB4NzAvMHhhNQpfX3JlcG9ydF9iYWRfaXJxKzB4MmUvMHhjMApub3RlX2ludGVycnVwdCsweDI0 OC8weDI5MAo/IGFkZF9pbnRlcnJ1cHRfcmFuZG9tbmVzcysweDMwLzB4MjIwCmhhbmRsZV9pcnFf ZXZlbnRfcGVyY3B1KzB4NTQvMHg4MApoYW5kbGVfaXJxX2V2ZW50KzB4MzkvMHg2MApoYW5kbGVf ZmFzdGVvaV9pcnErMHg5MS8weDE1MApoYW5kbGVfaXJxKzB4MTA4LzB4MTgwCmRvX0lSUSsweDUy LzB4ZjAKY29tbW9uX2ludGVycnVwdCsweGYvMHhmCjwvSVJRPgpSSVA6IDAwMzM6MHg3NmZjMmNm YWJjMWQKQ29kZTogMjQgMjggYmYgMDMgMDAgMDAgMDAgMzEgYzAgNDggOGQgMzUgNjMgNzcgMGUg MDAgNDggOGQgMTUgMmUKOTQgMGUgMDAgNGMgODkgZjkgNDkgODkgZDkgNGMgODkgZDMgZTggYjgg ZTIgMDEgMDAgNDggOGIgNTQgMjQgMTgKPDQ4PiA4OSBlZiA0OCA4OSBkZSA0YyA4OSBlMSBlOCBk NSA5NyAwMSAwMCA4NCBjMCA3NCAyZCA0OCA4YiAwNAoyNApSU1A6IDAwMmI6MDAwMDdmZmQyNDdj MWZjMCBFRkxBR1M6IDAwMDAwMjkzIE9SSUdfUkFYOiBmZmZmZmZmZmZmZmZmZmRhClJBWDogMDAw MDAwMDAwMDAwMDAwMCBSQlg6IDAwMDA3ZmZkMjQ3YzFmZjAgUkNYOiAwMDAwMDAwMDAwMDNkM2Nl ClJEWDogMDAwMDAwMDAwMDAwMDAwMCBSU0k6IDAwMDA3ZmZkMjQ3YzFmZjAgUkRJOiAwMDAwNzZm YzJjYmI2MDEwClJCUDogMDAwMDc2ZmMyY2RlZDAxMCBSMDg6IDAwMDA3ZmZkMjQ3YzIyMTAgUjA5 OiAwMDAwN2ZmZDI0N2MyMmEwClIxMDogMDAwMDc2ZmMyOTQ2NTQ3MCBSMTE6IDAwMDAwMDAwMDAw MDAwMDAgUjEyOiAwMDAwN2ZmZDI0N2MxZmMwClIxMzogMDAwMDc2ZmMyY2U4ZTQ3MCBSMTQ6IDAw MDA3NmZjMjdlYzk5NjAgUjE1OiAwMDAwMDAwMDAwMDAwNDE0CmhhbmRsZXJzOgpbPDAwMDAwMDAw MGQzZmE5MTM+XSBpZG1hNjRfaXJxCkRpc2FibGluZyBJUlEgIzI3CgpUbyBhdm9pZCBpbnRlcnJ1 cHQgc3Rvcm0sIHNldCB0aGUgZGV2aWNlIGluIHJlc2V0IHN0YXRlCmJlZm9yZSBicmluZ2luZyBv dXQgdGhlIGRldmljZSBmcm9tIHJlc2V0IHN0YXRlLgoKQ2hhbmdlbG9nIHYyOgotIGNvcnJlY3Qg dGhlIHN1YmplY3QgbGluZSBieSBhZGRpbmcgIm1mZDogIgoKU2lnbmVkLW9mZi1ieTogQmluYmlu IFd1IDxiaW5iaW4ud3VAaW50ZWwuY29tPgpBY2tlZC1ieTogTWlrYSBXZXN0ZXJiZXJnIDxtaWth Lndlc3RlcmJlcmdAbGludXguaW50ZWwuY29tPgotLS0KIGRyaXZlcnMvbWZkL2ludGVsLWxwc3Mu YyB8IDMgKysrCiAxIGZpbGUgY2hhbmdlZCwgMyBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEv ZHJpdmVycy9tZmQvaW50ZWwtbHBzcy5jIGIvZHJpdmVycy9tZmQvaW50ZWwtbHBzcy5jCmluZGV4 IDUwYmZmYzMuLmZmM2ZiYTEgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbWZkL2ludGVsLWxwc3MuYwor KysgYi9kcml2ZXJzL21mZC9pbnRlbC1scHNzLmMKQEAgLTI3Myw2ICsyNzMsOSBAQCBzdGF0aWMg dm9pZCBpbnRlbF9scHNzX2luaXRfZGV2KGNvbnN0IHN0cnVjdCBpbnRlbF9scHNzICpscHNzKQog ewogCXUzMiB2YWx1ZSA9IExQU1NfUFJJVl9TU1BfUkVHX0RJU19ETUFfRklOOwogCisJLyogU2V0 IHRoZSBkZXZpY2UgaW4gcmVzZXQgc3RhdGUgKi8KKwl3cml0ZWwoMCwgbHBzcy0+cHJpdiArIExQ U1NfUFJJVl9SRVNFVFMpOworCiAJaW50ZWxfbHBzc19kZWFzc2VydF9yZXNldChscHNzKTsKIAog CWludGVsX2xwc3Nfc2V0X3JlbWFwX2FkZHIobHBzcyk7Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCAE2C282CE for ; Mon, 8 Apr 2019 08:13:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A7C7920870 for ; Mon, 8 Apr 2019 08:13:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726068AbfDHIN6 (ORCPT ); Mon, 8 Apr 2019 04:13:58 -0400 Received: from mga17.intel.com ([192.55.52.151]:26946 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbfDHIN6 (ORCPT ); Mon, 8 Apr 2019 04:13:58 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Apr 2019 01:13:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,324,1549958400"; d="scan'208";a="159166913" Received: from wubinbin-desk.sh.intel.com ([10.239.143.112]) by fmsmga002.fm.intel.com with ESMTP; 08 Apr 2019 01:13:56 -0700 From: Binbin Wu To: rjw@rjwysocki.net, linux-pm@vger.kernel.org, gregkh@linuxfoundation.org, lee.jones@linaro.org, mika.westerberg@linux.intel.com, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, andriy.shevchenko@linux.intel.com Cc: binbin.wu@intel.com Subject: [PATCH v2] mfd: intel-lpss: Set the device in reset state when init Date: Mon, 8 Apr 2019 16:09:10 +0800 Message-Id: <1554710950-21212-1-git-send-email-binbin.wu@intel.com> X-Mailer: git-send-email 2.7.4 Sender: dmaengine-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: dmaengine@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Message-ID: <20190408080910.EARU56_EiBmOzz4UGpvEeKp2nlM0h6jg4V8IAFTVvxc@z> In virtualized setup, when system reboots due to warm reset interrupt storm is seen. Call Trace: dump_stack+0x70/0xa5 __report_bad_irq+0x2e/0xc0 note_interrupt+0x248/0x290 ? add_interrupt_randomness+0x30/0x220 handle_irq_event_percpu+0x54/0x80 handle_irq_event+0x39/0x60 handle_fasteoi_irq+0x91/0x150 handle_irq+0x108/0x180 do_IRQ+0x52/0xf0 common_interrupt+0xf/0xf RIP: 0033:0x76fc2cfabc1d Code: 24 28 bf 03 00 00 00 31 c0 48 8d 35 63 77 0e 00 48 8d 15 2e 94 0e 00 4c 89 f9 49 89 d9 4c 89 d3 e8 b8 e2 01 00 48 8b 54 24 18 <48> 89 ef 48 89 de 4c 89 e1 e8 d5 97 01 00 84 c0 74 2d 48 8b 04 24 RSP: 002b:00007ffd247c1fc0 EFLAGS: 00000293 ORIG_RAX: ffffffffffffffda RAX: 0000000000000000 RBX: 00007ffd247c1ff0 RCX: 000000000003d3ce RDX: 0000000000000000 RSI: 00007ffd247c1ff0 RDI: 000076fc2cbb6010 RBP: 000076fc2cded010 R08: 00007ffd247c2210 R09: 00007ffd247c22a0 R10: 000076fc29465470 R11: 0000000000000000 R12: 00007ffd247c1fc0 R13: 000076fc2ce8e470 R14: 000076fc27ec9960 R15: 0000000000000414 handlers: [<000000000d3fa913>] idma64_irq Disabling IRQ #27 To avoid interrupt storm, set the device in reset state before bringing out the device from reset state. Changelog v2: - correct the subject line by adding "mfd: " Signed-off-by: Binbin Wu Acked-by: Mika Westerberg --- drivers/mfd/intel-lpss.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c index 50bffc3..ff3fba1 100644 --- a/drivers/mfd/intel-lpss.c +++ b/drivers/mfd/intel-lpss.c @@ -273,6 +273,9 @@ static void intel_lpss_init_dev(const struct intel_lpss *lpss) { u32 value = LPSS_PRIV_SSP_REG_DIS_DMA_FIN; + /* Set the device in reset state */ + writel(0, lpss->priv + LPSS_PRIV_RESETS); + intel_lpss_deassert_reset(lpss); intel_lpss_set_remap_addr(lpss); -- 2.7.4