From: Paul Cercueil <paul@crapouillou.net>
To: Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me
Subject: Re: [PATCH] dma: jz4780: Make probe function __init_or_module
Date: Sat, 08 Jun 2019 12:23:49 +0200 [thread overview]
Message-ID: <1559989429.1815.7@crapouillou.net> (raw)
In-Reply-To: <20190607160758.16794-1-paul@crapouillou.net>
I misunderstood what __init_or_module was for. Please ignore this
patch. Sorry for the noise.
Le ven. 7 juin 2019 à 18:07, Paul Cercueil <paul@crapouillou.net> a
écrit :
> This allows the probe function to be dropped after the kernel finished
> its initialization, in the case where the driver was not compiled as a
> module.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
> drivers/dma/dma-jz4780.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index 7204fdeff6c5..b2f7e6660ad6 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -815,7 +815,7 @@ static struct dma_chan
> *jz4780_of_dma_xlate(struct of_phandle_args *dma_spec,
> }
> }
>
> -static int jz4780_dma_probe(struct platform_device *pdev)
> +static int __init_or_module jz4780_dma_probe(struct platform_device
> *pdev)
> {
> struct device *dev = &pdev->dev;
> const struct jz4780_dma_soc_data *soc_data;
> @@ -966,7 +966,7 @@ static int jz4780_dma_probe(struct
> platform_device *pdev)
> return ret;
> }
>
> -static int jz4780_dma_remove(struct platform_device *pdev)
> +static int __exit jz4780_dma_remove(struct platform_device *pdev)
> {
> struct jz4780_dma_dev *jzdma = platform_get_drvdata(pdev);
> int i;
> --
> 2.21.0.593.g511ec345e18
>
prev parent reply other threads:[~2019-06-08 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 16:07 [PATCH] dma: jz4780: Make probe function __init_or_module Paul Cercueil
2019-06-08 10:23 ` Paul Cercueil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559989429.1815.7@crapouillou.net \
--to=paul@crapouillou.net \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).