From: Vinod Koul <vkoul@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>,
Amelie Delaunay <amelie.delaunay@foss.st.com>
Cc: linux-stm32@st-md-mailman.stormreply.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: fix NULL pointer in channel unregistration function
Date: Thu, 21 Dec 2023 22:00:12 +0530 [thread overview]
Message-ID: <170317621281.683420.8268114839792721931.b4-ty@kernel.org> (raw)
In-Reply-To: <20231213160452.2598073-1-amelie.delaunay@foss.st.com>
On Wed, 13 Dec 2023 17:04:52 +0100, Amelie Delaunay wrote:
> __dma_async_device_channel_register() can fail. In case of failure,
> chan->local is freed (with free_percpu()), and chan->local is nullified.
> When dma_async_device_unregister() is called (because of managed API or
> intentionally by DMA controller driver), channels are unconditionally
> unregistered, leading to this NULL pointer:
> [ 1.318693] Unable to handle kernel NULL pointer dereference at virtual address 00000000000000d0
> [...]
> [ 1.484499] Call trace:
> [ 1.486930] device_del+0x40/0x394
> [ 1.490314] device_unregister+0x20/0x7c
> [ 1.494220] __dma_async_device_channel_unregister+0x68/0xc0
>
> [...]
Applied, thanks!
[1/1] dmaengine: fix NULL pointer in channel unregistration function
commit: f5c24d94512f1b288262beda4d3dcb9629222fc7
Best regards,
--
~Vinod
prev parent reply other threads:[~2023-12-21 16:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 16:04 [PATCH] dmaengine: fix NULL pointer in channel unregistration function Amelie Delaunay
2023-12-13 16:55 ` Dave Jiang
2023-12-21 16:30 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170317621281.683420.8268114839792721931.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=amelie.delaunay@foss.st.com \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox