DMA Engine development
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Amelie Delaunay <amelie.delaunay@foss.st.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	dmaengine@vger.kernel.org,
	linux-stm32@st-md-mailman.stormreply.com,
	Vinod Koul <vkoul@kernel.org>,
	devicetree@vger.kernel.org,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 01/11] dt-bindings: dma: stm32-dma3: prevent packing/unpacking mode
Date: Thu, 10 Oct 2024 13:11:21 -0500	[thread overview]
Message-ID: <172858388128.2107709.9101314940508767335.robh@kernel.org> (raw)
In-Reply-To: <20241010-dma3-mp25-updates-v1-1-adf0633981ea@foss.st.com>


On Thu, 10 Oct 2024 16:27:51 +0200, Amelie Delaunay wrote:
> When source data width/burst and destination data width/burst are
> different, data are packed or unpacked in DMA3 channel FIFO.
> Data are pushed out from DMA3 channel FIFO when the destination burst
> length (= data width * burst) is reached.
> If the channel is stopped before the transfer end, and if some bytes are
> packed/unpacked in the DMA3 channel FIFO, these bytes are lost.
> Indeed, DMA3 channel FIFO has no flush capability, only reset.
> To avoid potential bytes lost, pack/unpack must be prevented by setting
> memory data width/burst equal to peripheral data width/burst.
> Memory accesses will be penalized. But it is the only way to avoid bytes
> lost.
> 
> Some devices (e.g. cyclic RX like UART) need this, so add the possibility
> to prevent pack/unpack feature, by setting bit 16 of the 'DMA transfer
> requirements' bit mask.
> 
> Signed-off-by: Amelie Delaunay <amelie.delaunay@foss.st.com>
> ---
>  Documentation/devicetree/bindings/dma/stm32/st,stm32-dma3.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 

Acked-by: Rob Herring (Arm) <robh@kernel.org>


  reply	other threads:[~2024-10-10 18:11 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-10 14:27 [PATCH 00/11] STM32 DMA3 updates for STM32MP25 Amelie Delaunay
2024-10-10 14:27 ` [PATCH 01/11] dt-bindings: dma: stm32-dma3: prevent packing/unpacking mode Amelie Delaunay
2024-10-10 18:11   ` Rob Herring (Arm) [this message]
2024-10-10 14:27 ` [PATCH 02/11] dmaengine: stm32-dma3: prevent pack/unpack thanks to DT configuration Amelie Delaunay
2024-10-10 14:27 ` [PATCH 03/11] dmaengine: stm32-dma3: refactor HW linked-list to optimize memory accesses Amelie Delaunay
2024-10-10 14:27 ` [PATCH 04/11] dt-bindings: dma: stm32-dma3: prevent linked-list refactoring Amelie Delaunay
2024-10-10 18:14   ` Rob Herring
2024-10-11  9:01     ` Amelie Delaunay
2024-10-10 14:27 ` [PATCH 05/11] dmaengine: stm32-dma3: prevent LL refactoring thanks to DT configuration Amelie Delaunay
2024-10-10 14:27 ` [PATCH 06/11] dt-bindings: dma: stm32-dma3: introduce st,axi-max-burst-len property Amelie Delaunay
2024-10-10 18:16   ` Rob Herring
2024-10-11  9:12     ` Amelie Delaunay
2024-10-10 14:27 ` [PATCH 07/11] dmaengine: stm32-dma3: clamp AXI burst using st,axi-max-burst-len Amelie Delaunay
2024-10-10 14:27 ` [PATCH 08/11] arm64: dts: st: limit axi burst length in dma nodes of stm32mp25 Amelie Delaunay
2024-10-10 14:27 ` [PATCH 09/11] arm64: dts: st: add DMA support on U(S)ART instances " Amelie Delaunay
2024-10-10 14:28 ` [PATCH 10/11] arm64: dts: st: add DMA support on I2C " Amelie Delaunay
2024-10-10 14:28 ` [PATCH 11/11] arm64: dts: st: add DMA support on SPI " Amelie Delaunay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172858388128.2107709.9101314940508767335.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=amelie.delaunay@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox