From: Vinod Koul <vkoul@kernel.org>
To: Lizhi Hou <lizhi.hou@amd.com>, Brian Xu <brian.xu@amd.com>,
Raj Kumar Rampelli <raj.kumar.rampelli@amd.com>,
Michal Simek <michal.simek@amd.com>,
dmaengine@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Colin Ian King <colin.i.king@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][next] dmaengine: xilinx: xdma: remove redundant check on ret
Date: Mon, 02 Dec 2024 23:01:15 +0530 [thread overview]
Message-ID: <173316067527.538095.8720061974027462596.b4-ty@kernel.org> (raw)
In-Reply-To: <20241107114656.17611-1-colin.i.king@gmail.com>
On Thu, 07 Nov 2024 11:46:56 +0000, Colin Ian King wrote:
> The variable ret is being checked for an error and returning ret
> and the following statement returns ret too. The if check is
> redundant, and remove it. Just return the value returned from
> the call to regmap_write.
>
>
Applied, thanks!
[1/1] dmaengine: xilinx: xdma: remove redundant check on ret
commit: 0f31c0912286f84b34b15e39b286db8f4765ced8
Best regards,
--
~Vinod
prev parent reply other threads:[~2024-12-02 17:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 11:46 [PATCH][next] dmaengine: xilinx: xdma: remove redundant check on ret Colin Ian King
2024-12-02 17:31 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=173316067527.538095.8720061974027462596.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=brian.xu@amd.com \
--cc=colin.i.king@gmail.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizhi.hou@amd.com \
--cc=michal.simek@amd.com \
--cc=raj.kumar.rampelli@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox