From: "Rob Herring (Arm)" <robh@kernel.org>
To: Kaushal Kumar <quic_kaushalk@quicinc.com>
Cc: vigneshr@ti.com, andersson@kernel.org,
linux-mtd@lists.infradead.org, miquel.raynal@bootlin.com,
conor+dt@kernel.org, agross@kernel.org, krzk+dt@kernel.org,
linux-arm-msm@vger.kernel.org, richard@nod.at,
dmaengine@vger.kernel.org, vkoul@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
konradybcio@kernel.org, manivannan.sadhasivam@linaro.org
Subject: Re: [PATCH 1/6] dt-bindings: mtd: qcom,nandc: Document the SDX75 NAND
Date: Thu, 13 Mar 2025 09:31:09 -0500 [thread overview]
Message-ID: <174187626948.2759710.10340632443652482523.robh@kernel.org> (raw)
In-Reply-To: <20250313130918.4238-2-quic_kaushalk@quicinc.com>
On Thu, 13 Mar 2025 18:39:13 +0530, Kaushal Kumar wrote:
> Document the QPIC NAND controller v2.1.1 being used in
> SDX75 SoC and it uses BAM DMA.
>
> SDX75 NAND controller has DMA-coherent and iommu support
> so define them in the properties section, without which
> 'dtbs_check' reports the following error:
>
> nand-controller@1cc8000: Unevaluated properties are not
> allowed ('dma-coherent', 'iommus' were unexpected)
>
> Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com>
> ---
> .../devicetree/bindings/mtd/qcom,nandc.yaml | 23 ++++++++++++++-----
> 1 file changed, 17 insertions(+), 6 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml: properties:compatible: 'anyOf' conditional failed, one must be fixed:
'OneOf' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'dependentRequired', 'dependentSchemas', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
'type' was expected
from schema $id: http://devicetree.org/meta-schemas/keywords.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/qcom,nandc.yaml: properties:compatible: Additional properties are not allowed ('OneOf' was unexpected)
from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250313130918.4238-2-quic_kaushalk@quicinc.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2025-03-13 14:31 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 13:09 [PATCH 0/6] Enable QPIC BAM and QPIC NAND support for SDX75 Kaushal Kumar
2025-03-13 13:09 ` [PATCH 1/6] dt-bindings: mtd: qcom,nandc: Document the SDX75 NAND Kaushal Kumar
2025-03-13 14:31 ` Rob Herring (Arm) [this message]
2025-03-13 14:48 ` Krzysztof Kozlowski
2025-03-27 10:42 ` Kaushal Kumar
2025-03-13 13:09 ` [PATCH 2/6] dt-bindings: dma: qcom,bam: Document dma-coherent property Kaushal Kumar
2025-03-13 14:50 ` Krzysztof Kozlowski
2025-03-27 10:46 ` Kaushal Kumar
2025-03-13 13:09 ` [PATCH 3/6] ARM: dts: qcom: sdx75: Add QPIC BAM support Kaushal Kumar
2025-03-13 13:09 ` [PATCH 4/6] ARM: dts: qcom: sdx75: Add QPIC NAND support Kaushal Kumar
2025-03-13 14:36 ` Konrad Dybcio
2025-03-27 10:48 ` Kaushal Kumar
2025-03-13 14:50 ` Krzysztof Kozlowski
2025-03-27 10:47 ` Kaushal Kumar
2025-03-13 13:09 ` [PATCH 5/6] ARM: dts: qcom: sdx75-idp: Enable QPIC BAM support Kaushal Kumar
2025-03-13 14:37 ` Konrad Dybcio
2025-03-27 10:25 ` Kaushal Kumar
2025-03-13 13:09 ` [PATCH 6/6] ARM: dts: qcom: sdx75-idp: Enable QPIC NAND support Kaushal Kumar
2025-03-13 14:30 ` [PATCH 0/6] Enable QPIC BAM and QPIC NAND support for SDX75 Konrad Dybcio
2025-03-27 10:23 ` Kaushal Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=174187626948.2759710.10340632443652482523.robh@kernel.org \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=miquel.raynal@bootlin.com \
--cc=quic_kaushalk@quicinc.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox