From: Vinod Koul <vkoul@kernel.org>
To: Frank.Li@nxp.com, Zhen Ni <zhen.ni@easystack.cn>
Cc: imx@lists.linux.dev, dmaengine@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v4] dmaengine: fsl-edma: Fix clk leak on alloc_chan_resources failure
Date: Tue, 16 Dec 2025 22:26:21 +0530 [thread overview]
Message-ID: <176590418161.422798.10654079302568628725.b4-ty@kernel.org> (raw)
In-Reply-To: <20251014090522.827726-1-zhen.ni@easystack.cn>
On Tue, 14 Oct 2025 17:05:22 +0800, Zhen Ni wrote:
> When fsl_edma_alloc_chan_resources() fails after clk_prepare_enable(),
> the error paths only free IRQs and destroy the TCD pool, but forget to
> call clk_disable_unprepare(). This causes the channel clock to remain
> enabled, leaking power and resources.
>
> Fix it by disabling the channel clock in the error unwind path.
>
> [...]
Applied, thanks!
[1/1] dmaengine: fsl-edma: Fix clk leak on alloc_chan_resources failure
commit: b18cd8b210417f90537d914ffb96e390c85a7379
Best regards,
--
~Vinod
prev parent reply other threads:[~2025-12-16 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-14 9:05 [PATCH v4] dmaengine: fsl-edma: Fix clk leak on alloc_chan_resources failure Zhen Ni
2025-10-14 15:36 ` Frank Li
2025-12-03 22:14 ` Frank Li
2025-12-16 16:56 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=176590418161.422798.10654079302568628725.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=dmaengine@vger.kernel.org \
--cc=imx@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=zhen.ni@easystack.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox