From: Vinod Koul <vkoul@kernel.org>
To: Binbin Zhou <zhoubb.aaron@gmail.com>,
Frank Li <Frank.Li@kernel.org>,
dmaengine@vger.kernel.org, Huacai Chen <chenhuacai@kernel.org>,
Binbin Zhou <zhoubinbin@loongson.cn>
Cc: Huacai Chen <chenhuacai@kernel.org>,
Julia Lawall <julia.lawall@inria.fr>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] dmaengine: loongson: loongson2-apb-cmc: Fix signedness bug in irq handling
Date: Thu, 10 Sep 2026 19:40:17 +0530 [thread overview]
Message-ID: <178904941755.118320.15943723554182901056.b4-ty@kernel.org> (raw)
In-Reply-To: <20260818093448.3597016-1-zhoubinbin@loongson.cn>
On Tue, 18 Aug 2026 17:34:48 +0800, Binbin Zhou wrote:
> Storing that negative value into an unsigned variable makes the check
> `if (lchan->irq < 0)` always false, so probe errors are not correctly
> detected and propagated.
>
> Fix this by changing the type of `irq` to `int`, which allows proper
> signed comparison and error handling.
>
> [...]
Applied, thanks!
[1/1] dmaengine: loongson: loongson2-apb-cmc: Fix signedness bug in irq handling
commit: bf27ec04a888d4f1301a8da040719f2c332da681
Best regards,
--
~Vinod
prev parent reply other threads:[~2026-09-10 14:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-18 9:34 [PATCH] dmaengine: loongson: loongson2-apb-cmc: Fix signedness bug in irq handling Binbin Zhou
2026-08-18 9:49 ` sashiko-bot
2026-08-18 12:13 ` Huacai Chen
2026-08-18 16:39 ` Frank Li
2026-09-09 9:50 ` Binbin Zhou
2026-09-10 14:10 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178904941755.118320.15943723554182901056.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=julia.lawall@inria.fr \
--cc=lkp@intel.com \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox