DMA Engine development
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: dmaengine@vger.kernel.org, Rosen Penev <rosenp@gmail.com>
Cc: Frank Li <Frank.Li@kernel.org>,
	 Harninder Rai <harninder.rai@freescale.com>,
	 Xuelin Shi <xuelin.shi@freescale.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: fsl_raid: zero CF descriptor pool allocations
Date: Thu, 10 Sep 2026 19:40:26 +0530	[thread overview]
Message-ID: <178904942676.118320.14801400250683856639.b4-ty@kernel.org> (raw)
In-Reply-To: <20260820031654.28450-1-rosenp@gmail.com>


On Wed, 19 Aug 2026 20:16:54 -0700, Rosen Penev wrote:
> The compound frame descriptors and embedded CDBs are allocated from the
> cf_desc_pool with dma_pool_alloc(), which does not zero the memory. Only
> cdb32, the gfm coefficients and the frame address/length fields are
> programmed; the dpi_dest_spec/dpi_src_spec fields in the CDBs and the
> rbro32 field of each frame are left uninitialized. The hardware reads
> the whole block (frame 0 length is sizeof(struct fsl_re_xor_cdb) or
> sizeof(struct fsl_re_pq_cdb)), so uninitialized heap contents are
> exposed to the device on each new descriptor.
> 
> [...]

Applied, thanks!

[1/1] dmaengine: fsl_raid: zero CF descriptor pool allocations
      commit: 26d48e9fb6997f4026dd86daecf8d2c12258f698

Best regards,
-- 
~Vinod



      parent reply	other threads:[~2026-09-10 14:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-20  3:16 [PATCH] dmaengine: fsl_raid: zero CF descriptor pool allocations Rosen Penev
2026-08-20  3:28 ` sashiko-bot
2026-08-20 15:30 ` Frank Li
2026-09-10 14:10 ` Vinod Koul [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178904942676.118320.14801400250683856639.b4-ty@kernel.org \
    --to=vkoul@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=harninder.rai@freescale.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rosenp@gmail.com \
    --cc=xuelin.shi@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox