dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Vinod <vkoul@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Kieran Bingham <kieran@ksquared.org.uk>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	dmaengine@vger.kernel.org,
	Hiroki Negishi <hiroki.negishi.bx@renesas.com>
Subject: dmaengine: rcar-dmac: convert to SPDX identifiers
Date: Tue, 03 Jul 2018 08:49:01 +0300	[thread overview]
Message-ID: <1941522.TqLtPnU1Jj@avalon> (raw)

Hi Morimoto-san,

Thank you for the patch.

On Tuesday, 3 July 2018 03:29:59 EEST Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

A commit message would be nice :-)
 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  drivers/dma/sh/rcar-dmac.c | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c
> index 79d14af..322e57b 100644
> --- a/drivers/dma/sh/rcar-dmac.c
> +++ b/drivers/dma/sh/rcar-dmac.c
> @@ -1,14 +1,10 @@
> -/*
> - * Renesas R-Car Gen2 DMA Controller Driver
> - *
> - * Copyright (C) 2014 Renesas Electronics Inc.
> - *
> - * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> - *
> - * This is free software; you can redistribute it and/or modify
> - * it under the terms of version 2 of the GNU General Public License as
> - * published by the Free Software Foundation.
> - */
> +// SPDX-License-Identifier: GPL-2.0
> +//
> +// Renesas R-Car Gen2 DMA Controller Driver
> +//
> +// Copyright (C) 2014 Renesas Electronics Inc.
> +//
> +// Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I think the preferred comment style, accordingly to what other drivers do, is

// SPDX-License-Identifier: GPL-2.0
/*
 * Renesas R-Car Gen2 DMA Controller Driver
 *
 * Copyright (C) 2014 Renesas Electronics Inc.
 *
 * Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
 */

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  #include <linux/delay.h>
>  #include <linux/dma-mapping.h>

             reply	other threads:[~2018-07-03  5:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-03  5:49 Laurent Pinchart [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-07-03  6:38 dmaengine: rcar-dmac: convert to SPDX identifiers Vinod Koul
2018-07-03  6:25 Laurent Pinchart
2018-07-03  6:20 Vinod Koul
2018-07-03  0:29 Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1941522.TqLtPnU1Jj@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=hiroki.negishi.bx@renesas.com \
    --cc=kieran@ksquared.org.uk \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).