From: Sanjay R Mehta <sanmehta@amd.com>
To: Vinod Koul <vkoul@kernel.org>, Sanjay R Mehta <Sanju.Mehta@amd.com>
Cc: gregkh@linuxfoundation.org, dan.j.williams@intel.com,
Thomas.Lendacky@amd.com, Shyam-sundar.S-k@amd.com,
Nehal-bakulchandra.Shah@amd.com, robh@kernel.org,
mchehab+samsung@kernel.org, davem@davemloft.net,
linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org
Subject: Re: [PATCH v7 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource
Date: Thu, 18 Mar 2021 16:24:02 +0530 [thread overview]
Message-ID: <19466c1a-88a2-eeb2-77c0-9c0df1975713@amd.com> (raw)
In-Reply-To: <20201118121623.GR50232@vkoul-mobl>
>> + dma_dev->dst_addr_widths = PT_DMA_WIDTH(dma_get_mask(pt->dev));
>> + dma_dev->directions = DMA_MEM_TO_MEM;
>> + dma_dev->residue_granularity = DMA_RESIDUE_GRANULARITY_DESCRIPTOR;
>> + dma_cap_set(DMA_MEMCPY, dma_dev->cap_mask);
>> + dma_cap_set(DMA_INTERRUPT, dma_dev->cap_mask);
>> + dma_cap_set(DMA_PRIVATE, dma_dev->cap_mask);
>
> Why DMA_PRIVATE for a memcpy function?
This DMA engine is intended to use with AMD NTB IP and not for general purpose DMA, hence set the cap as DMA_PRIVATE.
Otherwise this DMA engine will be used for system DMA. Please correct me if my understanding is not right.
Also, I have implemented all of the comments for this patch except this. if this is fine, will send the next version for review.
Thanks,
Sanjay
> --
> ~Vinod
>
next prev parent reply other threads:[~2021-03-18 10:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-16 7:39 [PATCH v7 0/3] Add support for AMD PTDMA controller driver Sanjay R Mehta
2020-10-16 7:39 ` [PATCH v7 1/3] dmaengine: ptdma: Initial driver for the AMD PTDMA Sanjay R Mehta
2020-11-18 11:55 ` Vinod Koul
2021-03-18 10:46 ` Sanjay R Mehta
2021-03-22 6:04 ` Vinod Koul
2021-03-22 6:40 ` Sanjay R Mehta
2020-10-16 7:39 ` [PATCH v7 2/3] dmaengine: ptdma: register PTDMA controller as a DMA resource Sanjay R Mehta
2020-11-18 12:16 ` Vinod Koul
2020-11-24 14:23 ` Vitaly Mayatskih
2020-11-24 17:18 ` Vinod Koul
2020-11-24 17:37 ` Vitaly Mayatskih
2020-11-24 19:42 ` Sanjay R Mehta
2020-11-24 19:57 ` Sanjay R Mehta
2021-03-18 10:54 ` Sanjay R Mehta [this message]
2020-10-16 7:39 ` [PATCH v7 3/3] dmaengine: ptdma: Add debugfs entries for PTDMA information Sanjay R Mehta
2020-11-09 3:46 ` [PATCH v7 0/3] Add support for AMD PTDMA controller driver Sanjay R Mehta
2020-11-12 5:42 ` Sanjay R Mehta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19466c1a-88a2-eeb2-77c0-9c0df1975713@amd.com \
--to=sanmehta@amd.com \
--cc=Nehal-bakulchandra.Shah@amd.com \
--cc=Sanju.Mehta@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+samsung@kernel.org \
--cc=robh@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox