From: Vinod Koul <vinod.koul@intel.com>
To: Nicolas Chauvet <kwizart@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Lucas Stach <l.stach@pengutronix.de>,
dmaengine@vger.kernel.org
Subject: dmaengine: imx-sdma: Add MODULE_FIRMWARE
Date: Mon, 18 Dec 2017 08:53:52 +0530 [thread overview]
Message-ID: <20171218032352.GK18649@localhost> (raw)
On Wed, Dec 13, 2017 at 04:50:33PM +0100, Nicolas Chauvet wrote:
> This avoid the following error when using an initramfs on wandboard quad
> Direct firmware load for imx/sdma/sdma-imx6q.bin failed with error -2
Are you sure this fixes with latest kernel as the firmware in kernel has
been removed with commit 5620a0d1aacd: ("firmware: delete in-kernel
firmware")
> Signed-off-by: Nicolas Chauvet <kwizart@gmail.com>
> ---
> drivers/dma/imx-sdma.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index 2184881afe76..e7db24c67030 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1939,4 +1939,10 @@ module_platform_driver(sdma_driver);
>
> MODULE_AUTHOR("Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>");
> MODULE_DESCRIPTION("i.MX SDMA driver");
> +#if IS_ENABLED(CONFIG_SOC_IMX6Q)
> +MODULE_FIRMWARE("imx/sdma/sdma-imx6q.bin");
> +#endif
> +#if IS_ENABLED(CONFIG_SOC_IMX7D)
> +MODULE_FIRMWARE("imx/sdma/sdma-imx7d.bin");
> +#endif
> MODULE_LICENSE("GPL");
> --
> 2.13.6
>
next reply other threads:[~2017-12-18 3:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-18 3:23 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-12-22 12:05 dmaengine: imx-sdma: Add MODULE_FIRMWARE Vinod Koul
2017-12-18 14:48 Nicolas Chauvet
2017-12-13 15:50 Nicolas Chauvet
2017-12-12 11:37 Nicolas Chauvet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171218032352.GK18649@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kwizart@gmail.com \
--cc=l.stach@pengutronix.de \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).