From: Vinod Koul <vinod.koul@intel.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: sean.wang@mediatek.com, dan.j.williams@intel.com,
robh+dt@kernel.org, mark.rutland@arm.com,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Fengguang Wu <fengguang.wu@intel.com>
Subject: [v4,5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings
Date: Tue, 13 Feb 2018 12:16:59 +0530 [thread overview]
Message-ID: <20180213064659.GD3666@localhost> (raw)
On Fri, Feb 09, 2018 at 03:55:58PM +0100, Julia Lawall wrote:
>
> > > - ring->txd = dma_alloc_coherent(hsdma2dev(hsdma),
> > > - pc->sz_ring, &ring->tphys,
> > > - GFP_ATOMIC | __GFP_ZERO);
> > > + ring->txd = dma_zalloc_coherent(hsdma2dev(hsdma), pc->sz_ring,
> > > + &ring->tphys, GFP_ATOMIC);
> > > if (!ring->txd)
> > > return -ENOMEM;
> > >
> > > - memset(ring->txd, 0, pc->sz_ring);
> >
> > This should be folded back..
>
> Sorry, I'm not sure what you mean by "folded back".
Since the original patch is also up for review in this series, it doesn't
help much to add a change and fix on top in a series. The fix should be
folded back into the original commit. IIRC Fengguang's bot also recommends
so..
next reply other threads:[~2018-02-13 6:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-13 6:46 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-02-13 7:07 [v4,5/5] dmaengine: mediatek: fix zalloc-simple.cocci warnings Julia Lawall
2018-02-09 14:55 Julia Lawall
2018-02-09 12:58 Vinod Koul
2018-02-08 17:58 sean.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213064659.GD3666@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=fengguang.wu@intel.com \
--cc=julia.lawall@lip6.fr \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).