* [2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-26 16:12 mdf
0 siblings, 0 replies; 2+ messages in thread
From: mdf @ 2018-04-26 16:12 UTC (permalink / raw)
To: linux-kernel; +Cc: dmaengine, vinod.koul, dan.j.williams, lars, Moritz Fischer
Request IRQ with IRQF_SHARED flag. This works since the interrupt
handler already checks if there is an actual IRQ pending and returns
IRQ_NONE otherwise.
Signed-off-by: Moritz Fischer <mdf@kernel.org>
---
drivers/dma/dma-axi-dmac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index 75ccedaa96d2..2bd195532882 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -688,7 +688,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
goto err_unregister_device;
ret = devm_request_irq(&pdev->dev, dmac->irq,
- axi_dmac_interrupt_handler, 0,
+ axi_dmac_interrupt_handler, IRQF_SHARED,
dev_name(&pdev->dev), dmac);
if (ret)
goto err_unregister_of;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
@ 2018-04-26 16:27 Lars-Peter Clausen
0 siblings, 0 replies; 2+ messages in thread
From: Lars-Peter Clausen @ 2018-04-26 16:27 UTC (permalink / raw)
To: Moritz Fischer, linux-kernel; +Cc: dmaengine, vinod.koul, dan.j.williams
On 04/26/2018 06:12 PM, Moritz Fischer wrote:
> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> handler already checks if there is an actual IRQ pending and returns
> IRQ_NONE otherwise.
>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> drivers/dma/dma-axi-dmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 75ccedaa96d2..2bd195532882 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -688,7 +688,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
> goto err_unregister_device;
>
> ret = devm_request_irq(&pdev->dev, dmac->irq,
> - axi_dmac_interrupt_handler, 0,
> + axi_dmac_interrupt_handler, IRQF_SHARED,
> dev_name(&pdev->dev), dmac);
> if (ret)
> goto err_unregister_of;
>
---
To unsubscribe from this list: send the line "unsubscribe dmaengine" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-26 16:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-26 16:12 [2/2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED mdf
-- strict thread matches above, loose matches on Subject: below --
2018-04-26 16:27 Lars-Peter Clausen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).