From: Vinod Koul <vinod.koul@intel.com>
To: Moritz Fischer <mdf@kernel.org>
Cc: linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org,
dan.j.williams@intel.com, lars@metafoo.de
Subject: [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED
Date: Fri, 27 Apr 2018 10:41:15 +0530 [thread overview]
Message-ID: <20180427051115.GX6014@localhost> (raw)
On Thu, Apr 26, 2018 at 10:40:00AM -0700, Moritz Fischer wrote:
> Request IRQ with IRQF_SHARED flag. This works since the interrupt
> handler already checks if there is an actual IRQ pending and returns
> IRQ_NONE otherwise.
hmmm what are we trying to fix here? Is your device on a shared line or not?
>
> Acked-by: Lars-Peter Clausen <lars@metafoo.de>
> Signed-off-by: Moritz Fischer <mdf@kernel.org>
> ---
> Changes from v1:
> - Added Lars' Acked-by
> - Dropped patch [1/2] and changed accordingly
> ---
> drivers/dma/dma-axi-dmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
> index 2419fe524daa..15b2453d2647 100644
> --- a/drivers/dma/dma-axi-dmac.c
> +++ b/drivers/dma/dma-axi-dmac.c
> @@ -687,7 +687,7 @@ static int axi_dmac_probe(struct platform_device *pdev)
> if (ret)
> goto err_unregister_device;
>
> - ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, 0,
> + ret = request_irq(dmac->irq, axi_dmac_interrupt_handler, IRQF_SHARED,
> dev_name(&pdev->dev), dmac);
> if (ret)
> goto err_unregister_of;
> --
> 2.17.0
>
next reply other threads:[~2018-04-27 5:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 5:11 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-28 19:31 [v2] dmaengine: axi-dmac: Request IRQ with IRQF_SHARED mdf
2018-04-28 5:10 Vinod Koul
2018-04-27 15:18 Lars-Peter Clausen
2018-04-27 15:15 Moritz Fischer
2018-04-27 7:08 Vinod Koul
2018-04-27 6:53 Lars-Peter Clausen
2018-04-26 17:40 mdf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427051115.GX6014@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).