From: Vinod Koul <vinod.koul@linaro.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Wei Yongjun <weiyongjun1@huawei.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>, Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linaro.org>,
Chunyan Zhang <zhang.lyra@gmail.com>,
dmaengine@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [-next] dmaengine: sprd: Fix potential NULL dereference in sprd_dma_probe()
Date: Tue, 8 May 2018 17:35:34 +0530 [thread overview]
Message-ID: <20180508120534.GB22536@vkoul-mobl> (raw)
On 08-05-18, 13:46, Lars-Peter Clausen wrote:
> On 05/07/2018 03:40 AM, Wei Yongjun wrote:
> > res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > + if (!res)
> > + return -EINVAL;
> > sdev->glb_base = devm_ioremap_nocache(&pdev->dev, res->start,
> > resource_size(res));
>
> I think a better improvement would be to replace this with
> devm_ioremap_resource() which has the NULL pointer check and some other
> things built-in.
Sure feel free to send a patch :)
next reply other threads:[~2018-05-08 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 12:05 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-09 1:29 [-next] dmaengine: sprd: Fix potential NULL dereference in sprd_dma_probe() Baolin Wang
2018-05-08 12:10 Lars-Peter Clausen
2018-05-08 11:46 Lars-Peter Clausen
2018-05-07 8:04 Vinod Koul
2018-05-07 1:56 Baolin Wang
2018-05-07 1:40 weiyongjun (A)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508120534.GB22536@vkoul-mobl \
--to=vinod.koul@linaro.org \
--cc=baolin.wang@linaro.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=orsonzhai@gmail.com \
--cc=vkoul@kernel.org \
--cc=weiyongjun1@huawei.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox