DMA Engine development
 help / color / mirror / Atom feed
From: Vinod Koul <vinod.koul@linaro.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: dmaengine@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com>
Subject: [1/3] dmaengine: imx-sdma: Switch to SPDX identifier
Date: Tue, 22 May 2018 09:06:09 +0530	[thread overview]
Message-ID: <20180522033609.GA18351@vkoul-mobl> (raw)

On 21-05-18, 23:53, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> Adopt the SPDX license identifier headers to ease license compliance
> management.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  drivers/dma/imx-sdma.c | 29 +++++++++++------------------
>  1 file changed, 11 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
> index ccd03c3..f0779926 100644
> --- a/drivers/dma/imx-sdma.c
> +++ b/drivers/dma/imx-sdma.c
> @@ -1,21 +1,14 @@
> -/*
> - * drivers/dma/imx-sdma.c
> - *
> - * This file contains a driver for the Freescale Smart DMA engine
> - *
> - * Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>
> - *
> - * Based on code from Freescale:
> - *
> - * Copyright 2004-2009 Freescale Semiconductor, Inc. All Rights Reserved.
> - *
> - * The code contained herein is licensed under the GNU General Public
> - * License. You may obtain a copy of the GNU General Public License
> - * Version 2 or later at the following locations:
> - *
> - * http://www.opensource.org/licenses/gpl-license.html
> - * http://www.gnu.org/copyleft/gpl.html
> - */
> +// SPDX-License-Identifier: GPL-2.0+
> +//
> +// drivers/dma/imx-sdma.c
> +//
> +// This file contains a driver for the Freescale Smart DMA engine
> +//
> +// Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>
> +//
> +// Based on code from Freescale:
> +//
> +// Copyright 2004-2009 Freescale Semiconductor, Inc. All Rights Reserved.

Are you sure putting everything thru c99 style is apt. I have been told that we
should:

// SPDX-License-Identifier: GPL-2.0+
// Copyright 2010 Sascha Hauer, Pengutronix <s.hauer@pengutronix.de>

/*
 * rest of the comments you would like
 */

essentially SPDX tag and copyright should be c99 so that tools can parse, rest
information can be in regular linux comment style

             reply	other threads:[~2018-05-22  3:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-22  3:36 Vinod Koul [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-23  5:41 [1/3] dmaengine: imx-sdma: Switch to SPDX identifier Vinod Koul
2018-05-23  5:20 Vinod Koul
2018-05-22 11:22 Fabio Estevam
2018-05-22  2:53 Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180522033609.GA18351@vkoul-mobl \
    --to=vinod.koul@linaro.org \
    --cc=dmaengine@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox