From: Vinod Koul <vkoul@kernel.org>
To: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
Robin Gong <yibin.gong@nxp.com>
Cc: "dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"vinod.koul@intel.com" <vinod.koul@intel.com>,
dl-linux-imx <linux-imx@nxp.com>
Subject: [v1] dma: imx-sdma: add virt-dma support
Date: Wed, 23 May 2018 19:04:41 +0530 [thread overview]
Message-ID: <20180523133441.GK20991@vkoul-mobl> (raw)
On 23-05-18, 12:56, s.hauer@pengutronix.de wrote:
> Well, it's somewhat related to virtual dma support, but that's not my
> point. My point is that this patch is quite big and thus hard to review.
> If we find ways to make it smaller and to split it up in multiple
> patches then we should do so, because it makes it easier to review and
> in case you break something here we raise the chance that a "git bisect"
> lands on a smaller patch which is easier to understand.
>
> Please try and make that a separate change. I haven't really looked into
> it and it may not be possible due to reasons I haven't seen, but please
> at least give it a try.
That is something would help me as well. I have reviewed the patch and am not
sure I fully understand the changes, so breaking up stuff would definitely help
in the review..
next reply other threads:[~2018-05-23 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-23 13:34 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-05-24 1:42 [v1] dma: imx-sdma: add virt-dma support Robin Gong
2018-05-23 10:56 Sascha Hauer
2018-05-23 10:26 Robin Gong
2018-05-22 10:09 Sascha Hauer
2018-05-22 7:06 Robin Gong
2018-05-22 6:55 Vinod Koul
2018-05-22 6:16 Robin Gong
2018-03-22 16:18 Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180523133441.GK20991@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=vinod.koul@intel.com \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox