* [v5,1/7] tty: serial: imx: correct dma cookie status
@ 2018-06-19 16:56 Robin Gong
0 siblings, 0 replies; 3+ messages in thread
From: Robin Gong @ 2018-06-19 16:56 UTC (permalink / raw)
To: vkoul, s.hauer, l.stach, dan.j.williams, gregkh, jslaby
Cc: linux-serial, dmaengine, linux-kernel, linux-arm-kernel,
linux-imx
Correct to check the right rx dma cookie status in spit of it
works because only one cookie is running in the current sdma.
But it will not once sdma driver support multi cookies
running based on virt-dma.
Signed-off-by: Robin Gong <yibin.gong@nxp.com>
---
drivers/tty/serial/imx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 4e85357..2879407 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1051,7 +1051,7 @@ static void imx_uart_dma_rx_callback(void *data)
unsigned int r_bytes;
unsigned int bd_size;
- status = dmaengine_tx_status(chan, (dma_cookie_t)0, &state);
+ status = dmaengine_tx_status(chan, sport->rx_cookie, &state);
if (status == DMA_ERROR) {
imx_uart_clear_rx_errors(sport);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [v5,1/7] tty: serial: imx: correct dma cookie status
@ 2018-06-26 19:22 Uwe Kleine-König
0 siblings, 0 replies; 3+ messages in thread
From: Uwe Kleine-König @ 2018-06-26 19:22 UTC (permalink / raw)
To: Robin Gong
Cc: vkoul, s.hauer, l.stach, dan.j.williams, gregkh, jslaby,
dmaengine, linux-imx, linux-kernel, linux-serial,
linux-arm-kernel
On Wed, Jun 20, 2018 at 12:56:58AM +0800, Robin Gong wrote:
> Correct to check the right rx dma cookie status in spit of it
> works because only one cookie is running in the current sdma.
> But it will not once sdma driver support multi cookies
> running based on virt-dma.
>
> Signed-off-by: Robin Gong <yibin.gong@nxp.com>
Looks wrong (because of tx_status vs rx_cookie), but is right
nevertheless I think:
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Thanks
Uwe
> ---
> drivers/tty/serial/imx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> index 4e85357..2879407 100644
> --- a/drivers/tty/serial/imx.c
> +++ b/drivers/tty/serial/imx.c
> @@ -1051,7 +1051,7 @@ static void imx_uart_dma_rx_callback(void *data)
> unsigned int r_bytes;
> unsigned int bd_size;
>
> - status = dmaengine_tx_status(chan, (dma_cookie_t)0, &state);
> + status = dmaengine_tx_status(chan, sport->rx_cookie, &state);
>
> if (status == DMA_ERROR) {
> imx_uart_clear_rx_errors(sport);
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [v5,1/7] tty: serial: imx: correct dma cookie status
@ 2018-06-29 11:03 Vinod Koul
0 siblings, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2018-06-29 11:03 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Robin Gong, s.hauer, l.stach, dan.j.williams, gregkh, jslaby,
dmaengine, linux-imx, linux-kernel, linux-serial,
linux-arm-kernel
On 26-06-18, 21:22, Uwe Kleine-König wrote:
> On Wed, Jun 20, 2018 at 12:56:58AM +0800, Robin Gong wrote:
> > Correct to check the right rx dma cookie status in spit of it
> > works because only one cookie is running in the current sdma.
> > But it will not once sdma driver support multi cookies
> > running based on virt-dma.
> >
> > Signed-off-by: Robin Gong <yibin.gong@nxp.com>
> Looks wrong (because of tx_status vs rx_cookie), but is right
> nevertheless I think:
hehe, tx refers to transfer status for rx (receive) cookie and not
transmit .. yeah notations can be better!
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Thanks
> Uwe
>
> > ---
> > drivers/tty/serial/imx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> > index 4e85357..2879407 100644
> > --- a/drivers/tty/serial/imx.c
> > +++ b/drivers/tty/serial/imx.c
> > @@ -1051,7 +1051,7 @@ static void imx_uart_dma_rx_callback(void *data)
> > unsigned int r_bytes;
> > unsigned int bd_size;
> >
> > - status = dmaengine_tx_status(chan, (dma_cookie_t)0, &state);
> > + status = dmaengine_tx_status(chan, sport->rx_cookie, &state);
> >
> > if (status == DMA_ERROR) {
> > imx_uart_clear_rx_errors(sport);
> > --
> > 2.7.4
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-06-29 11:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-29 11:03 [v5,1/7] tty: serial: imx: correct dma cookie status Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-06-26 19:22 Uwe Kleine-König
2018-06-19 16:56 Robin Gong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).