From: Vinod Koul <vkoul@kernel.org>
To: dmaengine@vger.kernel.org
Cc: Robin Gong <yibin.gong@nxp.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Lucas Stach <l.stach@pengutronix.de>,
Vinod Koul <vkoul@kernel.org>
Subject: [3/3] dmaengine: imx-sdma: remove unused variable
Date: Mon, 2 Jul 2018 18:49:39 +0530 [thread overview]
Message-ID: <20180702131939.31481-3-vkoul@kernel.org> (raw)
The variable is no longer used, though it is set, so remove it
drivers/dma/imx-sdma.c:1298:6:
warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
int ret, i, count;
^~~
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/dma/imx-sdma.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c
index dfd1fbbe7ba8..b78146b4ea01 100644
--- a/drivers/dma/imx-sdma.c
+++ b/drivers/dma/imx-sdma.c
@@ -1295,7 +1295,7 @@ static struct dma_async_tx_descriptor *sdma_prep_slave_sg(
{
struct sdma_channel *sdmac = to_sdma_chan(chan);
struct sdma_engine *sdma = sdmac->sdma;
- int ret, i, count;
+ int i, count;
int channel = sdmac->channel;
struct scatterlist *sg;
struct sdma_desc *desc;
@@ -1318,17 +1318,14 @@ static struct dma_async_tx_descriptor *sdma_prep_slave_sg(
if (count > 0xffff) {
dev_err(sdma->dev, "SDMA channel %d: maximum bytes for sg entry exceeded: %d > %d\n",
channel, count, 0xffff);
- ret = -EINVAL;
goto err_bd_out;
}
bd->mode.count = count;
desc->chn_count += count;
- if (sdmac->word_size > DMA_SLAVE_BUSWIDTH_4_BYTES) {
- ret = -EINVAL;
+ if (sdmac->word_size > DMA_SLAVE_BUSWIDTH_4_BYTES)
goto err_bd_out;
- }
switch (sdmac->word_size) {
case DMA_SLAVE_BUSWIDTH_4_BYTES:
next reply other threads:[~2018-07-02 13:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 13:19 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-03 0:58 [3/3] dmaengine: imx-sdma: remove unused variable Robin Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702131939.31481-3-vkoul@kernel.org \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=l.stach@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox