From: Vinod Koul <vkoul@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Paul Cercueil <paul@crapouillou.net>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Mathieu Malaterre <malat@debian.org>,
Daniel Silsby <dansilsby@gmail.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: [05/14] dmaengine: dma-jz4780: Add support for the JZ4740 SoC
Date: Tue, 17 Jul 2018 21:04:07 +0530 [thread overview]
Message-ID: <20180717153407.GF3219@vkoul-mobl> (raw)
On 16-07-18, 15:33, Rob Herring wrote:
> On Mon, Jul 09, 2018 at 10:42:26PM +0530, Vinod wrote:
> > On 03-07-18, 14:32, Paul Cercueil wrote:
> >
> > > enum jz_version {
> > > + ID_JZ4740,
> > > ID_JZ4770,
> > > ID_JZ4780,
> > > };
> > > @@ -247,6 +248,7 @@ static void jz4780_dma_desc_free(struct virt_dma_desc *vdesc)
> > > }
> > >
> > > static const unsigned int jz4780_dma_ord_max[] = {
> > > + [ID_JZ4740] = 5,
> > > [ID_JZ4770] = 6,
> > > [ID_JZ4780] = 7,
> > > };
> > > @@ -801,11 +803,13 @@ static struct dma_chan *jz4780_of_dma_xlate(struct of_phandle_args *dma_spec,
> > > }
> > >
> > > static const unsigned int jz4780_dma_nb_channels[] = {
> > > + [ID_JZ4740] = 6,
> > > [ID_JZ4770] = 6,
> > > [ID_JZ4780] = 32,
> > > };
> >
> > I feel these should be done away with if we describe hardware in DT
>
> The compatible property can imply things like this.
So what is the general recommendation, let DT describe hardware
including version delta or use compatible to code that in driver?
Is it documented anywhere?
next reply other threads:[~2018-07-17 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-17 15:34 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-18 5:27 [05/14] dmaengine: dma-jz4780: Add support for the JZ4740 SoC Vinod Koul
2018-07-17 17:40 Rob Herring
2018-07-17 11:00 Paul Cercueil
2018-07-16 21:33 Rob Herring
2018-07-09 17:12 Vinod Koul
2018-07-04 16:52 PrasannaKumar Muralidharan
2018-07-03 12:32 Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180717153407.GF3219@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=dansilsby@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=ralf@linux-mips.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).