From: Vinod Koul <vkoul@kernel.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: dan.j.williams@intel.com, afaerber@suse.de, robh+dt@kernel.org,
dmaengine@vger.kernel.org, liuwei@actions-semi.com,
96boards@ucrobotics.com, devicetree@vger.kernel.org,
daniel.thompson@linaro.org, amit.kucheria@linaro.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, hzhang@ucrobotics.com,
bdong@ucrobotics.com, manivannanece23@gmail.com,
thomas.liau@actions-semi.com, jeff.chen@actions-semi.com,
pn@denx.de, edgar.righi@lsitec.org.br
Subject: [v2,1/4] dt-bindings: dma: Add binding for Actions Semi Owl SoCs
Date: Tue, 24 Jul 2018 17:46:04 +0530 [thread overview]
Message-ID: <20180724121604.GA2587@vkoul-mobl> (raw)
Hi Mani,
Patch title should be dmaengine: ... Please always use the apt tags and
one can find them using git log <subsystem>
On 23-07-18, 09:47, Manivannan Sadhasivam wrote:
> Add devicetree binding for Actions Semi Owl SoCs DMA controller.
It would help for review to describe the controller here
>
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> ---
> .../devicetree/bindings/dma/owl-dma.txt | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/owl-dma.txt
>
> diff --git a/Documentation/devicetree/bindings/dma/owl-dma.txt b/Documentation/devicetree/bindings/dma/owl-dma.txt
> new file mode 100644
> index 000000000000..dd6ce237b216
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/dma/owl-dma.txt
> @@ -0,0 +1,46 @@
> +* Actions Semi Owl SoCs DMA controller
> +
> +This binding follows the generic DMA bindings defined in dma.txt.
> +
> +Required properties:
> +- compatible: Should be "actions,s900-dma".
> +- reg: Should contain DMA registers location and length.
> +- interrupts: Should contain 4 interrupts shared by all channel.
> +- #dma-cells: Must be <1>. Used to represent the number of integer
> + cells in the dmas property of client device.
> +- dma-channels: Physical channels supported.
> +- dma-requests: Virtual channels supported.
not really, virtual channel is a software concepts. On the other hand
you may have request lines in hw and you can describe that, if not skip
this one
> +- clocks: Phandle and Specifier of the clock feeding the DMA controller.
> +
> +Example:
> +
> +Controller:
> + dma: dma-controller@e0260000 {
> + compatible = "actions,s900-dma";
> + reg = <0x0 0xe0260000 0x0 0x1000>;
> + interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
> + #dma-cells = <1>;
> + dma-channels = <12>;
> + dma-requests = <46>;
> + clocks = <&clock CLK_DMAC>;
> + };
> +
> +Client:
> +
> +DMA clients connected to the Actions Semi Owl SoCs DMA controller must
> +use the format described in the dma.txt file, using a two-cell specifier
> +for each channel.
> +
> +The two cells in order are:
> +1. A phandle pointing to the DMA controller.
> +2. The channel id.
> +
> +uart5: serial@e012a000 {
> + ...
> + dma-names = "tx", "rx";
> + dmas = <&dma 26>, <&dma 27>;
> + ...
> +};
> --
> 2.17.1
next reply other threads:[~2018-07-24 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 12:16 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-07-25 15:23 [v2,1/4] dt-bindings: dma: Add binding for Actions Semi Owl SoCs Manivannan Sadhasivam
2018-07-24 13:08 Vinod Koul
2018-07-24 12:19 Andreas Färber
2018-07-23 4:17 Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724121604.GA2587@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=96boards@ucrobotics.com \
--cc=afaerber@suse.de \
--cc=amit.kucheria@linaro.org \
--cc=bdong@ucrobotics.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=edgar.righi@lsitec.org.br \
--cc=hzhang@ucrobotics.com \
--cc=jeff.chen@actions-semi.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=liuwei@actions-semi.com \
--cc=manivannan.sadhasivam@linaro.org \
--cc=manivannanece23@gmail.com \
--cc=pn@denx.de \
--cc=robh+dt@kernel.org \
--cc=thomas.liau@actions-semi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox