From: Vinod Koul <vkoul@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Burton <paul.burton@mips.com>,
James Hogan <jhogan@kernel.org>,
Zubair Lutfullah Kakakhel <Zubair.Kakakhel@imgtec.com>,
Mathieu Malaterre <malat@debian.org>,
Daniel Silsby <dansilsby@gmail.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: [v3,07/18] dmaengine: dma-jz4780: Add support for the JZ4770 SoC
Date: Tue, 24 Jul 2018 21:31:40 +0530 [thread overview]
Message-ID: <20180724160140.GI3661@vkoul-mobl> (raw)
On 24-07-18, 17:04, Paul Cercueil wrote:
> Hi Vinod,
>
> Le mar. 24 juil. 2018 à 15:32, Vinod <vkoul@kernel.org> a écrit :
> > On 21-07-18, 13:06, Paul Cercueil wrote:
> > > +static inline void jz4780_dma_chan_enable(struct jz4780_dma_dev
> > > *jzdma,
> > > + unsigned int chn)
> >
> > right justified and aligned with preceding please. While adding new
> > code to a existing driver it is a good idea to conform to existing style
>
> OK.
>
> > > +{
> > > + if (jzdma->version == ID_JZ4770)
> > > + jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DCKES, BIT(chn));
> > > +}
> > > +
> > > +static inline void jz4780_dma_chan_disable(struct jz4780_dma_dev
> > > *jzdma,
> > > + unsigned int chn)
> > > +{
> > > + if (jzdma->version == ID_JZ4770)
> > > + jz4780_dma_ctrl_writel(jzdma, JZ_DMA_REG_DCKEC, BIT(chn));
> >
> > so if another version has this feature we would do:
> > if (jzdma->version == ID_JZ4770) ||
> > if (jzdma->version == ID_JZXXXX))
> >
> > and so on.. why not add a value, clk_enable in the description and use
> > that. For each controller it is set to true or false
>
> I agree with what you said in your other answers.
> However here I still need to check the "version", because on JZ4725B and
> JZ4770+
> the way to start/stop each DMA channel's clock is different, so I can't use
> a boolean
sure describe the behavior and use that. Versions is not a very scalable
way..
next reply other threads:[~2018-07-24 16:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-24 16:01 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-04 9:02 [v3,07/18] dmaengine: dma-jz4780: Add support for the JZ4770 SoC Paul Cercueil
2018-07-24 15:04 Paul Cercueil
2018-07-24 13:32 Vinod Koul
2018-07-21 11:06 Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180724160140.GI3661@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=Zubair.Kakakhel@imgtec.com \
--cc=dansilsby@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=malat@debian.org \
--cc=mark.rutland@arm.com \
--cc=paul.burton@mips.com \
--cc=paul@crapouillou.net \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox