From: Vinod Koul <vkoul@kernel.org>
To: Huang Shijie <sjhuang@iluvatar.ai>
Cc: dmaengine@vger.kernel.org, sudeep.dutt@intel.com,
ashutosh.dixit@intel.com
Subject: dma: mic_x100_dma: use devm_kzalloc to allocate mic_dma_dev
Date: Tue, 21 Aug 2018 17:04:28 +0530 [thread overview]
Message-ID: <20180821113428.GF2388@vkoul-mobl> (raw)
On 04-08-18, 10:15, Huang Shijie wrote:
> The following patch introduced an issue.
> dmaengine: mic_x100_dma: use the new helper to simplify the code
please use cannaonical form for describing patches i.e., commit abcdef:
("....") introduced ...
>
> This issue is :
>
> kfree(mic_dma_dev)
> .....
> dma_async_device_unregister(mic_dma_dev->device);
>
> Free the memory, and use it again.
>
> So use devm_kzalloc to allocate mic_dma_dev.
> When the Devres try to release the resources, it will call release at the
> following order:
>
> dma_async_device_unregister(mic_dma_dev->device);
> .....
> kfree(mic_dma_dev)
>
We should add:
Fixes: ...
And update the title to mention that this is a fix
> Signed-off-by: Huang Shijie <sjhuang@iluvatar.ai>
> ---
> drivers/dma/mic_x100_dma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/dma/mic_x100_dma.c b/drivers/dma/mic_x100_dma.c
> index b76cb17d879c..adfd316db1a8 100644
> --- a/drivers/dma/mic_x100_dma.c
> +++ b/drivers/dma/mic_x100_dma.c
> @@ -639,7 +639,7 @@ static struct mic_dma_device *mic_dma_dev_reg(struct mbus_device *mbdev,
> int ret;
> struct device *dev = &mbdev->dev;
>
> - mic_dma_dev = kzalloc(sizeof(*mic_dma_dev), GFP_KERNEL);
> + mic_dma_dev = devm_kzalloc(dev, sizeof(*mic_dma_dev), GFP_KERNEL);
> if (!mic_dma_dev) {
> ret = -ENOMEM;
> goto alloc_error;
> @@ -664,7 +664,6 @@ static struct mic_dma_device *mic_dma_dev_reg(struct mbus_device *mbdev,
> reg_error:
> mic_dma_uninit(mic_dma_dev);
> init_error:
> - kfree(mic_dma_dev);
> mic_dma_dev = NULL;
> alloc_error:
> dev_err(dev, "Error at %s %d ret=%d\n", __func__, __LINE__, ret);
> @@ -674,7 +673,6 @@ static struct mic_dma_device *mic_dma_dev_reg(struct mbus_device *mbdev,
> static void mic_dma_dev_unreg(struct mic_dma_device *mic_dma_dev)
> {
> mic_dma_uninit(mic_dma_dev);
> - kfree(mic_dma_dev);
> }
>
> /* DEBUGFS CODE */
> --
> 2.17.1
next reply other threads:[~2018-08-21 11:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 11:34 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-08-04 2:15 dma: mic_x100_dma: use devm_kzalloc to allocate mic_dma_dev Huang Shijie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180821113428.GF2388@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=ashutosh.dixit@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=sjhuang@iluvatar.ai \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox