From: Vinod Koul <vkoul@kernel.org>
To: Angelo Dureghello <angelo@sysam.it>
Cc: dmaengine@vger.kernel.org, sfr@canb.auug.org.au
Subject: [-next,v2] dmaengine: mcf-edma: fix x86_64 allmodconfig compilation warning
Date: Fri, 14 Sep 2018 17:18:32 +0530 [thread overview]
Message-ID: <20180914114832.GA2780@vkoul-mobl> (raw)
On 14-09-18, 09:11, Angelo Dureghello wrote:
> This patch fixes the compilation warning reported
> during x86_64 allmodconfig build.
How does it do so, I have no clue what to expect. Please describe the
change done here in the log...
Patch title also doesn't tell me anything about the fix.
>
> Reported-By: Stephen Rothwell <sfr@canb.auug.org.au>
> Signed-off-by: Angelo Dureghello <angelo@sysam.it>
> ---
> Changes for v2:
> - added Reported-By
> ---
> drivers/dma/mcf-edma.c | 3 ++-
> include/linux/platform_data/dma-mcf-edma.h | 2 +-
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dma/mcf-edma.c b/drivers/dma/mcf-edma.c
> index 4d30d5302649..e08e2409a102 100644
> --- a/drivers/dma/mcf-edma.c
> +++ b/drivers/dma/mcf-edma.c
> @@ -292,8 +292,9 @@ bool mcf_edma_filter_fn(struct dma_chan *chan, void *param)
> {
> if (chan->device->dev->driver == &mcf_edma_driver.driver) {
> struct fsl_edma_chan *mcf_chan = to_fsl_edma_chan(chan);
> + unsigned int req = *(unsigned int *)param;
>
> - return (mcf_chan->slave_id == (u32)param);
> + return (mcf_chan->slave_id == req);
> }
>
> return false;
> diff --git a/include/linux/platform_data/dma-mcf-edma.h b/include/linux/platform_data/dma-mcf-edma.h
> index d718ccfa3421..97cb79bda646 100644
> --- a/include/linux/platform_data/dma-mcf-edma.h
> +++ b/include/linux/platform_data/dma-mcf-edma.h
> @@ -21,7 +21,7 @@ struct dma_slave_map;
>
> bool mcf_edma_filter_fn(struct dma_chan *chan, void *param);
>
> -#define MCF_EDMA_FILTER_PARAM(ch) ((void *)ch)
> +#define MCF_EDMA_FILTER_PARAM(ch) ((int[]) { (ch) })
I dont think you answered me about this, why is this change required and
in the context of current patch, what does it fix?
next reply other threads:[~2018-09-14 11:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-14 11:48 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-14 18:51 [-next,v2] dmaengine: mcf-edma: fix x86_64 allmodconfig compilation warning Angelo Dureghello
2018-09-14 12:13 Angelo Dureghello
2018-09-14 11:35 Geert Uytterhoeven
2018-09-14 7:11 Angelo Dureghello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180914114832.GA2780@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=angelo@sysam.it \
--cc=dmaengine@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox