From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Vinod Koul <vkoul@kernel.org>
Cc: dmaengine@vger.kernel.org, Viresh Kumar <vireshk@kernel.org>
Subject: [05/12] dmaengine: dw: remove dma_slave_config direction usage
Date: Fri, 21 Sep 2018 20:03:18 +0300 [thread overview]
Message-ID: <20180921170318.GB15943@smile.fi.intel.com> (raw)
On Tue, Sep 11, 2018 at 02:05:29PM +0530, Vinod Koul wrote:
> dma_slave_config direction was marked as deprecated quite some
> time back, remove the usage from this driver so that the field
> can be removed
It looks like we assign direction field in custom struct any time when we call
one of ->*prep*() functions, so, it's safe to be removed from ->config().
Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> CC: Viresh Kumar <vireshk@kernel.org>
> CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> drivers/dma/dw/core.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c
> index f43e6dafe446..d0c3e50b39fb 100644
> --- a/drivers/dma/dw/core.c
> +++ b/drivers/dma/dw/core.c
> @@ -886,12 +886,7 @@ static int dwc_config(struct dma_chan *chan, struct dma_slave_config *sconfig)
> */
> u32 s = dw->pdata->is_idma32 ? 1 : 2;
>
> - /* Check if chan will be configured for slave transfers */
> - if (!is_slave_direction(sconfig->direction))
> - return -EINVAL;
> -
> memcpy(&dwc->dma_sconfig, sconfig, sizeof(*sconfig));
> - dwc->direction = sconfig->direction;
>
> sc->src_maxburst = sc->src_maxburst > 1 ? fls(sc->src_maxburst) - s : 0;
> sc->dst_maxburst = sc->dst_maxburst > 1 ? fls(sc->dst_maxburst) - s : 0;
> --
> 2.14.4
>
next reply other threads:[~2018-09-21 17:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-21 17:03 Andy Shevchenko [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-09-11 8:35 [05/12] dmaengine: dw: remove dma_slave_config direction usage Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921170318.GB15943@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox