From: Angelo Dureghello <angelo@sysam.it>
To: Vinod <vkoul@kernel.org>
Cc: Krzysztof Kozlowski <krzk@kernel.org>, dmaengine@vger.kernel.org
Subject: [v2] dmaengine: fsl-edma: remove dma_slave_config direction usage
Date: Tue, 9 Oct 2018 10:00:21 +0200 [thread overview]
Message-ID: <20181009080021.GA3345@jerusalem> (raw)
Hi Vinod,
On Tue, Oct 09, 2018 at 01:00:01PM +0530, Vinod wrote:
> On 09-10-18, 09:22, Krzysztof Kozlowski wrote:
> > On Sun, 7 Oct 2018 at 16:15, Vinod Koul <vkoul@kernel.org> wrote:
> > >
> > > dma_slave_config direction was marked as deprecated quite some
> > > time back, remove the usage from this driver so that the field
> > > can be removed
> > >
> > > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > > ---
> > > CC: Angelo Dureghello <angelo@sysam.it>
> > > CC: Krzysztof Kozlowski <krzk@kernel.org>
> > >
> > > Angelo, Krzysztof,
> > >
> > > I have rebased this against the latest fsl-edma changes, can you
> > > please verify this and let me know, thnx
> >
> > I applied it on top of linux next (20181008) and compilation fails:
> >
> > ../drivers/i2c/busses/i2c-imx.c: In function ‘i2c_imx_dma_request’:
> > ../drivers/i2c/busses/i2c-imx.c:298:13: error: ‘struct
> > dma_slave_config’ has no member named ‘direction’
> > dma_sconfig.direction = DMA_MEM_TO_DEV;
> > ^
> > ../drivers/i2c/busses/i2c-imx.c:315:13: error: ‘struct
> > dma_slave_config’ has no member named ‘direction’
> > dma_sconfig.direction = DMA_DEV_TO_MEM;
> > ^
> >
> > ../drivers/mmc/host/mmci.c: In function ‘__mmci_dma_prep_data’:
> > ../drivers/mmc/host/mmci.c:578:7: error: ‘struct dma_slave_config’ has
> > no member named ‘direction’
> > conf.direction = DMA_DEV_TO_MEM;
> > ^
> > ../drivers/mmc/host/mmci.c:581:7: error: ‘struct dma_slave_config’ has
> > no member named ‘direction’
> > conf.direction = DMA_MEM_TO_DEV;
> > ^
> > ../drivers/mmc/host/mmci.c:604:14: error: ‘struct dma_slave_config’
> > has no member named ‘direction’
> > conf.direction, flags);
> > ^
> >
> > Am I missing some dependencies?
>
> Nope, the dmaengine.h change I used to verify removing off all instances
> has crept up in this, sorry for that.
>
> Can you remove the deletion and try again, I will post v3 as well
>
Thanks for the patch, looks like i left this out from my previous set.
I re-added direction to struct dma_slave_config and tested the patch on both
stmark2 (ColdFire mcf5441x) and Colibri VF50 with Krzysztof Kozlowski
proceq_vf_bck_defconfig + vf500-colibri-eval-v3.dtb.
At least for ColdFire DSPI + DMA, and console + DMA on Colibri, all seems
to work properly.
Tested-by: Angelo Dureghello <angelo@sysam.it>
> --
> ~Vinod
Regards,
Angelo
next reply other threads:[~2018-10-09 8:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 8:00 Angelo Dureghello [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-10-09 7:30 [v2] dmaengine: fsl-edma: remove dma_slave_config direction usage Vinod Koul
2018-10-09 7:22 Krzysztof Kozlowski
2018-10-07 14:14 Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009080021.GA3345@jerusalem \
--to=angelo@sysam.it \
--cc=dmaengine@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).