DMA Engine development
 help / color / mirror / Atom feed
From: Vinod Koul <vkoul@kernel.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org,
	grygorii.strashko@ti.com
Subject: [RFC,1/5] dmaengine: Add support for reporting DMA cached data amount
Date: Tue, 9 Oct 2018 16:17:55 +0530	[thread overview]
Message-ID: <20181009104755.GK2372@vkoul-mobl> (raw)

On 24-09-18, 16:00, Peter Ujfalusi wrote:
> A DMA hardware can have big cache or FIFO and the amount of data sitting in
> the DMA fabric can be an interest for the clients.
> 
> For example in audio we want to know the delay in the data flow and in case
> the DMA have significantly large FIFO/cache, it can affect the latenc/delay

this looks okay to me, but not really up for 'cached', better
alternates?

Also we need to update Documentation for this..

> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/dma/dmaengine.h   | 7 +++++++
>  include/linux/dmaengine.h | 2 ++
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/dma/dmaengine.h b/drivers/dma/dmaengine.h
> index 501c0b063f85..80214270b70e 100644
> --- a/drivers/dma/dmaengine.h
> +++ b/drivers/dma/dmaengine.h
> @@ -77,6 +77,7 @@ static inline enum dma_status dma_cookie_status(struct dma_chan *chan,
>  		state->last = complete;
>  		state->used = used;
>  		state->residue = 0;
> +		state->cached = 0;
>  	}
>  	return dma_async_is_complete(cookie, complete, used);
>  }
> @@ -87,6 +88,12 @@ static inline void dma_set_residue(struct dma_tx_state *state, u32 residue)
>  		state->residue = residue;
>  }
>  
> +static inline void dma_set_cached(struct dma_tx_state *state, u32 cached)
> +{
> +	if (state)
> +		state->cached = cached;
> +}
> +
>  struct dmaengine_desc_callback {
>  	dma_async_tx_callback callback;
>  	dma_async_tx_callback_result callback_result;
> diff --git a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> index 10ff71b13eef..16c9d021988a 100644
> --- a/include/linux/dmaengine.h
> +++ b/include/linux/dmaengine.h
> @@ -701,11 +701,13 @@ static inline struct dma_async_tx_descriptor *txd_next(struct dma_async_tx_descr
>   * @residue: the remaining number of bytes left to transmit
>   *	on the selected transfer for states DMA_IN_PROGRESS and
>   *	DMA_PAUSED if this is implemented in the driver, else 0
> + * @cached: amount of data in bytes cached by the DMA.
>   */
>  struct dma_tx_state {
>  	dma_cookie_t last;
>  	dma_cookie_t used;
>  	u32 residue;
> +	u32 cached;
>  };
>  
>  /**
> -- 
> Peter
> 
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

             reply	other threads:[~2018-10-09 10:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-09 10:47 Vinod Koul [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-09 11:41 [RFC,1/5] dmaengine: Add support for reporting DMA cached data amount Vinod Koul
2018-10-09 11:05 Peter Ujfalusi
2018-09-24 13:00 Peter Ujfalusi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181009104755.GK2372@vkoul-mobl \
    --to=vkoul@kernel.org \
    --cc=dan.j.williams@intel.com \
    --cc=dmaengine@vger.kernel.org \
    --cc=grygorii.strashko@ti.com \
    --cc=peter.ujfalusi@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox