dmaengine.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ben Dooks <ben.dooks@codethink.co.uk>
To: dan.j.williams@intel.co, vkoul@kernel.org
Cc: ldewangan@nvidia.com, dmaengine@vger.kernel.org,
	linux-tegra@vger.kernel.org,
	Ben Dooks <ben.dooks@codethink.co.uk>,
	Ingo Molnar <mingo@redhat.com>,
	Steven Rostedt <rostedt@goodmis.org>
Subject: [6/6] dma: tegra: add tracepoint for residual update
Date: Fri, 12 Oct 2018 10:44:54 +0100	[thread overview]
Message-ID: <20181012094454.22841-7-ben.dooks@codethink.co.uk> (raw)

Add a tracepoint in the residual update instead of using dev_dbg()
to allow debugging via the trace pipe.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Ingo Molnar <mingo@redhat.com> (maintainer:TRACING)
Cc: Steven Rostedt <rostedt@goodmis.org> (maintainer:TRACING)
---
 drivers/dma/tegra20-apb-dma.c        |  5 ++---
 include/trace/events/tegra_apb_dma.h | 27 +++++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
index 96095a3b7edd..495cda6c21b9 100644
--- a/drivers/dma/tegra20-apb-dma.c
+++ b/drivers/dma/tegra20-apb-dma.c
@@ -886,9 +886,8 @@ static unsigned int tegra_dma_update_residual(struct tegra_dma_channel *tdc,
 	}
 
 done:	
-	dev_dbg(tdc2dev(tdc), "residual: req %08lx, ahb@%08lx, wcount %08lx, done %d\n",
-		 sg_req->ch_regs.ahb_ptr, ahbptr, wcount, done);
-
+	trace_tegra_dma_tx_state(&tdc->dma_chan, ahbptr, status, result,
+				 tmp, residual);
 	return result;
 }
 
diff --git a/include/trace/events/tegra_apb_dma.h b/include/trace/events/tegra_apb_dma.h
index 80d6f0cf4c36..a686f98a9c8b 100644
--- a/include/trace/events/tegra_apb_dma.h
+++ b/include/trace/events/tegra_apb_dma.h
@@ -43,6 +43,33 @@ TRACE_EVENT(tegra_dma_complete_cb,
 		      __entry->count, __entry->ptr)
 );
 
+TRACE_EVENT(tegra_dma_tx_state,
+	    TP_PROTO(struct dma_chan *dc, unsigned long ahb,
+		     unsigned long wc, unsigned int done,
+		     unsigned long byte_count, unsigned int residual),
+	    TP_ARGS(dc, ahb, wc, done, byte_count, residual),
+	    TP_STRUCT__entry(
+		    __field(struct dma_chan *,	dc)
+		    __field(unsigned long,	ahb)
+		    __field(unsigned long,	wc)
+		    __field(unsigned long,	done)
+		    __field(unsigned int,	residual)
+		    __field(unsigned long,	byte_count)
+		    ),
+	    TP_fast_assign(
+		    __entry->dc = dc;
+		    __entry->ahb = ahb;
+		    __entry->wc = wc;
+		    __entry->done = done;
+		    __entry->residual = residual;
+		    __entry->byte_count = byte_count;
+		    ),
+	    TP_printk("%s: txresidual: ahb %08lx wc %08lx => done %lu bc %lu residual %u",
+		      dev_name(&__entry->dc->dev->device),
+		      __entry->ahb, __entry->wc, __entry->done,
+		      __entry->byte_count, __entry->residual)
+);
+
 TRACE_EVENT(tegra_dma_isr,
 	    TP_PROTO(struct dma_chan *dc, int irq),
 	    TP_ARGS(dc, irq),

             reply	other threads:[~2018-10-12  9:44 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-12  9:44 Ben Dooks [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-10-12 17:04 [6/6] dma: tegra: add tracepoint for residual update Steven Rostedt
2018-10-31 14:08 Ben Dooks
2018-10-31 16:03 Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181012094454.22841-7-ben.dooks@codethink.co.uk \
    --to=ben.dooks@codethink.co.uk \
    --cc=dan.j.williams@intel.co \
    --cc=dmaengine@vger.kernel.org \
    --cc=ldewangan@nvidia.com \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).