From: Vinod Koul <vkoul@kernel.org>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: linus.walleij@linaro.org, dan.j.williams@intel.com,
linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: dma: coh901318: Fix a double-lock bug
Date: Sat, 24 Nov 2018 20:00:35 +0530 [thread overview]
Message-ID: <20181124143035.GJ3175@vkoul-mobl.Dlink> (raw)
On 06-11-18, 11:33, Jia-Ju Bai wrote:
> The function coh901318_alloc_chan_resources() calls spin_lock_irqsave()
> before calling coh901318_config().
> But coh901318_config() calls spin_lock_irqsave() again in its
> definition, which may cause a double-lock bug.
>
> Because coh901318_config() is only called by
> coh901318_alloc_chan_resources(), the bug fix is to remove the
> calls to spin-lock and -unlock functions in coh901318_config().
Applied after fixing subsystem tag, thanks
next reply other threads:[~2018-11-24 14:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 14:30 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-11-14 13:36 dma: coh901318: Fix a double-lock bug Linus Walleij
2018-11-06 3:33 Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181124143035.GJ3175@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=baijiaju1990@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox