From: Joerg Roedel <joro@8bytes.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: iommu@lists.linux-foundation.org,
Russell Currey <ruscur@russell.cc>,
Sam Bobroff <sbobroff@linux.ibm.com>,
oohall@gmail.com,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Hanjun Guo <hanjun.guo@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>,
jroedel@suse.de, Mathias Nyman <mathias.nyman@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
dmaengine@vger.kernel.org, linux-usb@vger.kernel.org
Subject: [1/6] driver core: Introduce device_iommu_mapped() function
Date: Tue, 11 Dec 2018 16:18:06 +0100 [thread overview]
Message-ID: <20181211151806.GQ16835@8bytes.org> (raw)
On Tue, Dec 11, 2018 at 05:59:33PM +0300, Sergei Shtylyov wrote:
> > +static inline bool device_iommu_mapped(struct device *dev)
> > +{
> > + return (dev->iommu_group != NULL);
>
> You know that parens are unnecessary here, right? :-)
Yes, I know, but it feels incomplete to me without them :-)
Joerg
next reply other threads:[~2018-12-11 15:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 15:18 Joerg Roedel [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-12-17 9:31 [1/6] driver core: Introduce device_iommu_mapped() function Joerg Roedel
2018-12-17 6:11 Vinod Koul
2018-12-12 11:07 Joerg Roedel
2018-12-12 11:04 Greg Kroah-Hartman
2018-12-11 14:59 Sergei Shtylyov
2018-12-11 13:43 Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181211151806.GQ16835@8bytes.org \
--to=joro@8bytes.org \
--cc=benh@kernel.crashing.org \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hanjun.guo@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mathias.nyman@intel.com \
--cc=mpe@ellerman.id.au \
--cc=oohall@gmail.com \
--cc=paulus@samba.org \
--cc=ruscur@russell.cc \
--cc=sbobroff@linux.ibm.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=sudeep.holla@arm.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).