* [2/3] dmaengine: Extend the k3dma driver binding
@ 2018-12-28 6:36 h00249924
0 siblings, 0 replies; 3+ messages in thread
From: h00249924 @ 2018-12-28 6:36 UTC (permalink / raw)
To: dmaengine, devicetree, linux-kernel, linux-arm-kernel
Cc: suzhuangluan, kongfei, liyuequan, cash.qianli, huangli295,
hantanglei, wangyoulin1, ninggaoyu, hanxiaolong3, Youlin Wang,
Vinod Koul, Rob Herring, Mark Rutland
From: Youlin Wang <wwx575822@notesmail.huawei.com>
Extend the k3dma driver binding to support hisi-asp hardware variants.
Signed-off-by: Youlin Wang <wwx575822@notesmail.huawei.com>
Signed-off-by: Tanglei Han <hantanglei@huawei.com>
Cc: Vinod Koul <vkoul@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>
---
Documentation/devicetree/bindings/dma/k3dma.txt | 33 ++++++++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt b/Documentation/devicetree/bindings/dma/k3dma.txt
index 4945aea..cd21b82 100644
--- a/Documentation/devicetree/bindings/dma/k3dma.txt
+++ b/Documentation/devicetree/bindings/dma/k3dma.txt
@@ -3,7 +3,9 @@
See dma.txt first
Required properties:
-- compatible: Should be "hisilicon,k3-dma-1.0"
+- compatible: Must be one of
+- "hisilicon,k3-dma-1.0"
+- "hisilicon,hisi-pcm-asp-dma-1.0"
- reg: Should contain DMA registers location and length.
- interrupts: Should contain one interrupt shared by all channel
- #dma-cells: see dma.txt, should be 1, para number
@@ -43,3 +45,32 @@ For example, i2c0 read channel request line is 18, while write channel use 19
dma-names = "rx", "tx";
};
+
+
+
+Controller:
+ asp_dmac: asp_dmac@E804B000 {
+ compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
+ reg = <0x0 0xe804b000 0x0 0x1000>;
+ #dma-cells = <1>;
+ dma-channels = <16>;
+ dma-requests = <32>;
+ dma-min-chan = <0>;
+ dma-used-chans = <0xFFFE>;
+ dma-share;
+ interrupts = <0 216 4>;
+ interrupt-names = "asp_dma_irq";
+ status = "ok";
+ };
+
+Client:
+ i2s2: hisi_i2s {
+ compatible = "hisilicon,hisi-i2s";
+ reg = <0x0 0xe804f800 0x0 0x400>,
+ <0x0 0xe804e000 0x0 0x400>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&i2s2_pmx_func &i2s2_cfg_func>;
+ dmas = <&asp_dmac 18 &asp_dmac 19>;
+ dma-names = "rx", "tx";
+ #sound-dai-cells = <0>;
+ };
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [2/3] dmaengine: Extend the k3dma driver binding
@ 2019-01-02 18:00 John Stultz
0 siblings, 0 replies; 3+ messages in thread
From: John Stultz @ 2019-01-02 18:00 UTC (permalink / raw)
To: h00249924
Cc: dmaengine,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, lkml,
linux-arm-kernel, Mark Rutland, wwx575822, hanxiaolong3,
Zhuangluan Su, Hantanglei, Kongfei, ninggaoyu, Vinod Koul,
Rob Herring, Liyuequan, huangli (I), wangyoulin, Qianli (A)
On Thu, Dec 27, 2018 at 10:39 PM h00249924 <hutenghui@huawei.com> wrote:
>
> From: Youlin Wang <wwx575822@notesmail.huawei.com>
>
> Extend the k3dma driver binding to support hisi-asp hardware variants.
>
> Signed-off-by: Youlin Wang <wwx575822@notesmail.huawei.com>
> Signed-off-by: Tanglei Han <hantanglei@huawei.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> ---
> Documentation/devicetree/bindings/dma/k3dma.txt | 33 ++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt b/Documentation/devicetree/bindings/dma/k3dma.txt
> index 4945aea..cd21b82 100644
> --- a/Documentation/devicetree/bindings/dma/k3dma.txt
> +++ b/Documentation/devicetree/bindings/dma/k3dma.txt
> @@ -3,7 +3,9 @@
> See dma.txt first
>
> Required properties:
> -- compatible: Should be "hisilicon,k3-dma-1.0"
> +- compatible: Must be one of
> +- "hisilicon,k3-dma-1.0"
> +- "hisilicon,hisi-pcm-asp-dma-1.0"
> - reg: Should contain DMA registers location and length.
> - interrupts: Should contain one interrupt shared by all channel
> - #dma-cells: see dma.txt, should be 1, para number
> @@ -43,3 +45,32 @@ For example, i2c0 read channel request line is 18, while write channel use 19
> dma-names = "rx", "tx";
> };
>
> +
> +
> +
> +Controller:
> + asp_dmac: asp_dmac@E804B000 {
> + compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> + reg = <0x0 0xe804b000 0x0 0x1000>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
> + dma-requests = <32>;
> + dma-min-chan = <0>;
> + dma-used-chans = <0xFFFE>;
> + dma-share;
Thanks for sending this out!
So min-chan, used-chans and dma-share aren't in the existing binding
document. So they probably should be removed from this example, or the
binding document needs to be updated first.
thanks
-john
^ permalink raw reply [flat|nested] 3+ messages in thread
* [2/3] dmaengine: Extend the k3dma driver binding
@ 2019-01-03 23:21 Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2019-01-03 23:21 UTC (permalink / raw)
To: h00249924
Cc: dmaengine, devicetree, linux-kernel, linux-arm-kernel,
suzhuangluan, kongfei, liyuequan, cash.qianli, huangli295,
hantanglei, wangyoulin1, ninggaoyu, hanxiaolong3, Youlin Wang,
Vinod Koul, Mark Rutland
On Fri, Dec 28, 2018 at 02:36:22PM +0800, h00249924 wrote:
> From: Youlin Wang <wwx575822@notesmail.huawei.com>
>
> Extend the k3dma driver binding to support hisi-asp hardware variants.
>
> Signed-off-by: Youlin Wang <wwx575822@notesmail.huawei.com>
> Signed-off-by: Tanglei Han <hantanglei@huawei.com>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> ---
> Documentation/devicetree/bindings/dma/k3dma.txt | 33 ++++++++++++++++++++++++-
> 1 file changed, 32 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/k3dma.txt b/Documentation/devicetree/bindings/dma/k3dma.txt
> index 4945aea..cd21b82 100644
> --- a/Documentation/devicetree/bindings/dma/k3dma.txt
> +++ b/Documentation/devicetree/bindings/dma/k3dma.txt
> @@ -3,7 +3,9 @@
> See dma.txt first
>
> Required properties:
> -- compatible: Should be "hisilicon,k3-dma-1.0"
> +- compatible: Must be one of
> +- "hisilicon,k3-dma-1.0"
> +- "hisilicon,hisi-pcm-asp-dma-1.0"
> - reg: Should contain DMA registers location and length.
> - interrupts: Should contain one interrupt shared by all channel
> - #dma-cells: see dma.txt, should be 1, para number
> @@ -43,3 +45,32 @@ For example, i2c0 read channel request line is 18, while write channel use 19
> dma-names = "rx", "tx";
> };
>
> +
> +
> +
> +Controller:
Why is a new example needed just for a new compatible string?
> + asp_dmac: asp_dmac@E804B000 {
> + compatible = "hisilicon,hisi-pcm-asp-dma-1.0";
> + reg = <0x0 0xe804b000 0x0 0x1000>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
> + dma-requests = <32>;
> + dma-min-chan = <0>;
> + dma-used-chans = <0xFFFE>;
> + dma-share;
> + interrupts = <0 216 4>;
> + interrupt-names = "asp_dma_irq";
> + status = "ok";
> + };
> +
> +Client:
> + i2s2: hisi_i2s {
> + compatible = "hisilicon,hisi-i2s";
> + reg = <0x0 0xe804f800 0x0 0x400>,
> + <0x0 0xe804e000 0x0 0x400>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2s2_pmx_func &i2s2_cfg_func>;
> + dmas = <&asp_dmac 18 &asp_dmac 19>;
> + dma-names = "rx", "tx";
> + #sound-dai-cells = <0>;
> + };
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-03 23:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-03 23:21 [2/3] dmaengine: Extend the k3dma driver binding Rob Herring
-- strict thread matches above, loose matches on Subject: below --
2019-01-02 18:00 John Stultz
2018-12-28 6:36 h00249924
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).