From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/3] dma: imx-sdma: fix NULL pointer de-reference From: Angus Ainslie Message-Id: <20190120015851.11797-2-angus@akkea.ca> Date: Sat, 19 Jan 2019 18:58:49 -0700 To: angus@akkea.ca Cc: Vinod Koul , dmaengine@vger.kernel.org, NXP Linux Team , Pengutronix Kernel Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-ID: T24gdGhlIGlteDhtcSBJIGdldCBOVUxMIHBvaW50ZXIgZGUtZGVmZXJlbmNlIGVycm9ycyBpZiB0 aGUgZGV2aWNlCmlzbid0IHBhc3NlZCBpbiBkdXJpbmcgYWxsb2NhdGlvbi4KClNpZ25lZC1vZmYt Ynk6IEFuZ3VzIEFpbnNsaWUgKFB1cmlzbSkgPGFuZ3VzQGFra2VhLmNhPgotLS0KIGRyaXZlcnMv ZG1hL2lteC1zZG1hLmMgfCAxNyArKysrKysrKystLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDkg aW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2RtYS9p bXgtc2RtYS5jIGIvZHJpdmVycy9kbWEvaW14LXNkbWEuYwppbmRleCA4NjcwOGZiOWJkYTEuLjA2 NGJjNTBkMWU5OSAxMDA2NDQKLS0tIGEvZHJpdmVycy9kbWEvaW14LXNkbWEuYworKysgYi9kcml2 ZXJzL2RtYS9pbXgtc2RtYS5jCkBAIC02NzcsNyArNjc3LDcgQEAgc3RhdGljIGludCBzZG1hX2xv YWRfc2NyaXB0KHN0cnVjdCBzZG1hX2VuZ2luZSAqc2RtYSwgdm9pZCAqYnVmLCBpbnQgc2l6ZSwK IAlpbnQgcmV0OwogCXVuc2lnbmVkIGxvbmcgZmxhZ3M7CiAKLQlidWZfdmlydCA9IGRtYV9hbGxv Y19jb2hlcmVudChOVUxMLCBzaXplLCAmYnVmX3BoeXMsIEdGUF9LRVJORUwpOworCWJ1Zl92aXJ0 ID0gZG1hX2FsbG9jX2NvaGVyZW50KHNkbWEtPmRldiwgc2l6ZSwgJmJ1Zl9waHlzLCBHRlBfS0VS TkVMKTsKIAlpZiAoIWJ1Zl92aXJ0KSB7CiAJCXJldHVybiAtRU5PTUVNOwogCX0KQEAgLTY5Niw3 ICs2OTYsNyBAQCBzdGF0aWMgaW50IHNkbWFfbG9hZF9zY3JpcHQoc3RydWN0IHNkbWFfZW5naW5l ICpzZG1hLCB2b2lkICpidWYsIGludCBzaXplLAogCiAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgm c2RtYS0+Y2hhbm5lbF8wX2xvY2ssIGZsYWdzKTsKIAotCWRtYV9mcmVlX2NvaGVyZW50KE5VTEws IHNpemUsIGJ1Zl92aXJ0LCBidWZfcGh5cyk7CisJZG1hX2ZyZWVfY29oZXJlbnQoc2RtYS0+ZGV2 LCBzaXplLCBidWZfdmlydCwgYnVmX3BoeXMpOwogCiAJcmV0dXJuIHJldDsKIH0KQEAgLTExODIs OCArMTE4Miw4IEBAIHN0YXRpYyBpbnQgc2RtYV9yZXF1ZXN0X2NoYW5uZWwwKHN0cnVjdCBzZG1h X2VuZ2luZSAqc2RtYSkKIHsKIAlpbnQgcmV0ID0gLUVCVVNZOwogCi0Jc2RtYS0+YmQwID0gZG1h X2FsbG9jX2NvaGVyZW50KE5VTEwsIFBBR0VfU0laRSwgJnNkbWEtPmJkMF9waHlzLAotCQkJCSAg ICAgICBHRlBfTk9XQUlUKTsKKwlzZG1hLT5iZDAgPSBkbWFfemFsbG9jX2NvaGVyZW50KHNkbWEt PmRldiwgUEFHRV9TSVpFLCAmc2RtYS0+YmQwX3BoeXMsCisJCQkJCUdGUF9OT1dBSVQpOwogCWlm ICghc2RtYS0+YmQwKSB7CiAJCXJldCA9IC1FTk9NRU07CiAJCWdvdG8gb3V0OwpAQCAtMTIwNSw4 ICsxMjA1LDggQEAgc3RhdGljIGludCBzZG1hX2FsbG9jX2JkKHN0cnVjdCBzZG1hX2Rlc2MgKmRl c2MpCiAJdTMyIGJkX3NpemUgPSBkZXNjLT5udW1fYmQgKiBzaXplb2Yoc3RydWN0IHNkbWFfYnVm ZmVyX2Rlc2NyaXB0b3IpOwogCWludCByZXQgPSAwOwogCi0JZGVzYy0+YmQgPSBkbWFfYWxsb2Nf Y29oZXJlbnQoTlVMTCwgYmRfc2l6ZSwgJmRlc2MtPmJkX3BoeXMsCi0JCQkJICAgICAgR0ZQX05P V0FJVCk7CisJZGVzYy0+YmQgPSBkbWFfemFsbG9jX2NvaGVyZW50KGRlc2MtPnNkbWFjLT5zZG1h LT5kZXYsIGJkX3NpemUsCisJCQkmZGVzYy0+YmRfcGh5cywJR0ZQX05PV0FJVCk7CiAJaWYgKCFk ZXNjLT5iZCkgewogCQlyZXQgPSAtRU5PTUVNOwogCQlnb3RvIG91dDsKQEAgLTEyMTksNyArMTIx OSw4IEBAIHN0YXRpYyB2b2lkIHNkbWFfZnJlZV9iZChzdHJ1Y3Qgc2RtYV9kZXNjICpkZXNjKQog ewogCXUzMiBiZF9zaXplID0gZGVzYy0+bnVtX2JkICogc2l6ZW9mKHN0cnVjdCBzZG1hX2J1ZmZl cl9kZXNjcmlwdG9yKTsKIAotCWRtYV9mcmVlX2NvaGVyZW50KE5VTEwsIGJkX3NpemUsIGRlc2Mt PmJkLCBkZXNjLT5iZF9waHlzKTsKKwlkbWFfZnJlZV9jb2hlcmVudChkZXNjLT5zZG1hYy0+c2Rt YS0+ZGV2LCBiZF9zaXplLCBkZXNjLT5iZCwKKwkJCWRlc2MtPmJkX3BoeXMpOwogfQogCiBzdGF0 aWMgdm9pZCBzZG1hX2Rlc2NfZnJlZShzdHJ1Y3QgdmlydF9kbWFfZGVzYyAqdmQpCkBAIC0xODQy LDcgKzE4NDMsNyBAQCBzdGF0aWMgaW50IHNkbWFfaW5pdChzdHJ1Y3Qgc2RtYV9lbmdpbmUgKnNk bWEpCiAJLyogQmUgc3VyZSBTRE1BIGhhcyBub3Qgc3RhcnRlZCB5ZXQgKi8KIAl3cml0ZWxfcmVs YXhlZCgwLCBzZG1hLT5yZWdzICsgU0RNQV9IX0MwUFRSKTsKIAotCXNkbWEtPmNoYW5uZWxfY29u dHJvbCA9IGRtYV9hbGxvY19jb2hlcmVudChOVUxMLAorCXNkbWEtPmNoYW5uZWxfY29udHJvbCA9 IGRtYV9hbGxvY19jb2hlcmVudChzZG1hLT5kZXYsCiAJCQlNQVhfRE1BX0NIQU5ORUxTICogc2l6 ZW9mIChzdHJ1Y3Qgc2RtYV9jaGFubmVsX2NvbnRyb2wpICsKIAkJCXNpemVvZihzdHJ1Y3Qgc2Rt YV9jb250ZXh0X2RhdGEpLAogCQkJJmNjYl9waHlzLCBHRlBfS0VSTkVMKTsK