From: Vinod Koul <vkoul@kernel.org>
To: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Cc: Jose Abreu <jose.abreu@synopsys.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>,
Eugeniy Paltsev <eugeniy.paltsev@synopsys.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Niklas Cassel <niklas.cassel@linaro.org>,
Joao Pinto <joao.pinto@synopsys.com>,
Luis de Oliveira <luis.oliveira@synopsys.com>,
Vitor Soares <vitor.soares@synopsys.com>,
Nelson Costa <nelson.costa@synopsys.com>,
Pedro Sousa <pedrom.sousa@synopsys.com>
Subject: [RFC,v3,1/7] dmaengine: Add Synopsys eDMA IP core driver
Date: Sun, 20 Jan 2019 17:17:24 +0530 [thread overview]
Message-ID: <20190120114724.GW4635@vkoul-mobl> (raw)
On 16-01-19, 11:53, Gustavo Pimentel wrote:
> >> + /* Free irqs */
> >
> > But devm will automatically free it, no ?
>
> Yes, it shouldn't be there. I'll remove it.
Nope this is correct. we need to ensure irqs are freed and tasklets are
quiesced otherwise you can end up with a case when a spurious interrupt
and then tasklets spinning while core unrolls. devm for irq is not a
good idea unless you really know what you are doing!
next reply other threads:[~2019-01-20 11:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-20 11:47 Vinod Koul [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-02-06 18:06 [RFC,v3,1/7] dmaengine: Add Synopsys eDMA IP core driver Gustavo Pimentel
2019-02-02 10:07 Vinod Koul
2019-02-01 11:23 Gustavo Pimentel
2019-02-01 4:14 Vinod Koul
2019-01-31 11:33 Gustavo Pimentel
2019-01-23 13:08 Vinod Koul
2019-01-21 15:49 Gustavo Pimentel
2019-01-21 15:48 Gustavo Pimentel
2019-01-21 9:14 Gustavo Pimentel
2019-01-20 11:44 Vinod Koul
2019-01-19 16:21 Andy Shevchenko
2019-01-16 11:53 Gustavo Pimentel
2019-01-16 10:21 Jose Abreu
2019-01-11 18:33 Gustavo Pimentel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190120114724.GW4635@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=eugeniy.paltsev@synopsys.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=joao.pinto@synopsys.com \
--cc=jose.abreu@synopsys.com \
--cc=linux-pci@vger.kernel.org \
--cc=luis.oliveira@synopsys.com \
--cc=nelson.costa@synopsys.com \
--cc=niklas.cassel@linaro.org \
--cc=pedrom.sousa@synopsys.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vitor.soares@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox